Review: Needs Fixing
* init/main.c:
- handle_logdir(): Is there a reason we are not honouring the environment
variable? If not, why don't we put
the 'dir = getenv (LOGDIR_ENV)' immediately before the 'if (user_mode)'
since we can then say in the
user_mode block: 'log_dir = dir ? dir : get_user_log_dir ()' and thus
honour the env var for user mode too.
* init/xdg.c:
- get_user_log_dir():
- Spacing around '='.
- 'path' is leaked.
- We should be logging to $HOME/.cache/upstart/logs/ as per the spec: this
allows us to create a
$HOME/.cache/upstart/sessions/ also in the spec.
* init/man/init.5: This needs updating for '--user' and location of
conf files and logfiles when running in this mode. Specifically the following
sections need updating:
- 'User Jobs'
- 'Process environment' -> console -> log
- 'FILES': should reflect conf directories listed in the 'User
Session Mode' and specify location of User Session log files.
* init/man/init.8: Description of '--logdir' and '--confdir' also need updating.
--
https://code.launchpad.net/~xnox/upstart/user-log-dir/+merge/143091
Your team Upstart Reviewers is subscribed to branch lp:upstart.
--
upstart-devel mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/upstart-devel
