> Sounds good. Yes, please update the spec. > > Please can you also update the doc as outlined in original comments. Also... > > * init/xdg.c: > xdg_get_cache_home(): XDG_CACHE_HOME and ".cache" should be defined in > init/paths.h for consistency.
Why? I only defined upstart specific constants in path.h, e.g. INIT_XDG_SUBDIR - the name of the subdirectory we use within all XDG_* locations. XDG_* variables are not upstart specific and are compliant with the XDG spec. Also their fallbacks "/etc/xdg/", "~/.config", "~/.cache" are defined in the XDG spec. I am failing to see benefits or introducing #ifndef pointers to those names, since changing those will violate XDG specification. And XDG specification is unlikely to change in a backwards incompatible way at this point. Note that XDG_CONFIG_HOME, XDG_CONFIG_DIRS, "~/.config", "/etc/xdg/" are not defined in paths.h. If libnih starts using XDG_* paths for anything, it might even make sense to move xdg_ helper functions into libnih. I guess I can make a static array of those constants at the top of xdg.c for ease of understanding that these constants are externally specified. -- https://code.launchpad.net/~xnox/upstart/user-log-dir/+merge/143091 Your team Upstart Reviewers is subscribed to branch lp:upstart. -- upstart-devel mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/upstart-devel
