On Monday 25 January 2010 09:45:03 Jie Zhang wrote:
> I'm starting to merge all our local changes of UrJTAG into upstream.
> 
> This patch adds Blackfin commands to UrJTAG. Most of the patch is in
> /sur/bfin/ directory and so not very intrusive. Besides these Blackfin
> specific code, I also

i wonder if we should start a src/cpu/ or src/arch/ tree and put bfin under 
there ?

along these lines, we should probably start a new configure option for people 
to control which cpus they want to enable support for ... so if they dont want 
blackfin stuff in their jtag build, they can do:
--enable-cpus=none

the bfin.h header should use #ifdef protection naming like all the other 
headers, and when it includes local urjtag headers, it should use "..." not 
<urjtag/...>.

the type convention is to declare the struct in all caps in the respective 
file and to have the types.h do the typedef to the lowercase xxx_t.  i'm 
referring to the urj_part_{params,init} stuff.

there's a few mingw pieces in the Blackfin code that should get moved to 
sysdep.h.

> * add URJ_ERROR_BFIN to enum URJ_ERROR

if we generalize the cpu dirs, then this could be made into a generic 
URJ_ERROR_CPU so other cpu/ could reuse it ?  it'd be "cpu-specific subsystem" 
then ...

> * add a new field 'main_part' to struct URJ_CHAIN
> 
> * add a new filed 'params' to struct URJ_PART and its related
> initialization functions.

could you describe these new pieces a bit more in detail ?  like why we had to 
extend the common pieces when no other pieces needed it ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to