On 02/10/2010 05:20 AM, Mike Frysinger wrote: > On Monday 08 February 2010 10:02:50 Jie Zhang wrote: >> This UrJTAG patch, which is attached in this email, does not change the >> default settings. But it changes --with-libusb to to accept "1.0" and >> "0.1". This patch also checks if libftdi is the new one. It will check >> if the combination of libusb version and libftdi version is good. For >> example, libusb-1.0 cannot be used with the old libftdi. libusb-0.1 >> cannot be used with the new libftdi. It changes usbconn_ftdi_flush to >> utilize the asynchronous mode of the new libftdi. So we can enlarge the >> receive buffer to (63 * 64). See the email on the above URL for further >> explanation. >> >> Since this patch does not change the default settings of UrJTAG, it's >> not intrusive. I'm going to commit it in 24 ~ 48 hours if no one objects. > > it introduces a warning and in looking at the code, i can see why ... > usbconn/libftdi.c: In function ‘usbconn_ftdi_flush’: > usbconn/libftdi.c:72: warning: ‘tc’ may be used uninitialized in this function
I noticed this. But I thought it was a false alert of GCC, so I just left it to see if I could find some time to take a look at GCC. But apparently, I don't find such time. I will commit the patch with tc initialized to NULL to suppress this warning. Jie ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
