On Tuesday, October 19, 2010 16:40:57 Tomek CEDRO wrote: > On Tue, Oct 19, 2010 at 9:12 PM, Mike Frysinger <[email protected]> wrote: > >> --- src/tap/cable_list.h (wersja 1862) > >> +++ src/tap/cable_list.h (kopia robocza) > >> --- src/tap/cable/generic_usbconn_list.h (wersja 1862) > >> +++ src/tap/cable/generic_usbconn_list.h (kopia robocza) > > > > keep the list sorted at least within itself (the ft2232 cables) > > ktlink is just after usbscarab2.
... and "k" is alphabetically before "u". the header files shouldnt have the same order as the source file. the header file order bubbles up into the user interface in terms of ordering. > >> + params_t *params = (params_t *) cable->params; > > > > drop the useless cast > > not sure of that - everywhere in the code this syntax is used, so i > dont want to mess with casting. > > >> + urj_tap_cable_cx_cmd_root_t *cmd_root = &(params->cmd_root); > > > > no need for the paranethesis. applies to multiple places in the patch. > > again, used code from other code sections. bad code isnt an excuse for adding more broken code. ive fixed the code in the tree in these two regards. > >> + params->low_byte_value = 0; > >> + params->low_byte_value |= BITMASK_TMS; > >> + params->low_byte_value |= BITMASK_KTLINK_TMSDOsel ; > > > > no need for multiple assignments. just do it once. > > this is more readable as the one assignment would make code multiline > and messy. this is common practice to set bitmasks this way, no need > to spare some few bytes. so you pick which parts of the file to deviate from ? just before you were saying you wanted to keep the wrong cast/address style because the rest of the file was doing it wrong, but now you want to use the wrong style because you think it's better ? > > and no space before the semicolon. > > btw. why do you use function parse "function ()" instead "function()" ? not my preference. but that is what the tree uses now. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platforms. Download your free trials today! http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
