On Tue, Oct 19, 2010 at 11:15 PM, Mike Frysinger <[email protected]> wrote:
>> again, used code from other code sections.
>
> bad code isnt an excuse for adding more broken code.  ive fixed the code in
> the tree in these two regards.

gjt :-)

> so you pick which parts of the file to deviate from ?  just before you were
> saying you wanted to keep the wrong cast/address style because the rest of the
> file was doing it wrong, but now you want to use the wrong style because you
> think it's better ?

I want to keep the cast because I am not familiar enough with the code
to judge what happens if I omit the cast - from what I remember
casting and no casting can produce different result (ie casting to
void or similar) and I don't want to break the code - so I did just as
the others before me :-) Using different parse and different operation
is distinguishable for me - whether I perform some operation or not,
and perform some operation in multiple lines/steps. I think this parse
I have used is simply more readable (in my vim) and often used in
embedded programming, but if you prefer to see it in one line, please
modify the code as you like - for me it is important that it works
well :-)

Best regards,
Tomek


-- 
CeDeROM, SQ7MHZ, http://www.tomek.cedro.info

------------------------------------------------------------------------------
Download new Adobe(R) Flash(R) Builder(TM) 4
The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly 
Flex(R) Builder(TM)) enable the development of rich applications that run
across multiple browsers and platforms. Download your free trials today!
http://p.sf.net/sfu/adobe-dev2dev
_______________________________________________
UrJTAG-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/urjtag-development

Reply via email to