On Wednesday, July 06, 2011 18:04:03 Jonathan Stroud wrote:
> +int (*urj_flash_detect[]) (urj_bus_t *bus, uint32_t adr,
> + urj_flash_cfi_array_t **cfi_array) = {mark this static/const since it's only used here i think we'll want to add a dedicated type for this rather than declaring it freehand like this. urj_flash_detect_func_t. also, name the array "urj_flash_detect_funcs". > + NULL /* last must be NULL */ if it's only defined locally, we dont need a NULL terminator. just use "i < ARRAY_SIZE (urj_flash_detect)". style still needs some tweaking: - spaces, not tabs - "i = 0" - the opening braces should be on dedicated lines otherwise, the idea seems fine -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
