Here is api change patch:
busdriver_api_change.patch
Description: Binary data
On Jul 6, 2011, at 5:24 PM, Mike Frysinger wrote: > On Wednesday, July 06, 2011 16:29:27 Jonathan Stroud wrote: >> Here is the first patch that updates the bus driver API. > > shouldnt the bus class be part of the driver rather than the area ? i cant > see this being useful as a runtime tunable. then you can add URJ_BUS_CLS() > to > get at the field rather than getting it from the area. > > enums typically are declared by themselves rather than inline in a struct. > see how URJ_BUS_PARAM_KEY is handled. > > i'm more partial to calling it a bus type rather than bus class. personally > i > find it to be clearer, but maybe that's me. > > i see some tabs that should be indented with spaces, but otherwise seems fine. > -mike
------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
