I think we might want to do more than just log in this case. Here enabling the option is a good suggestion for possibly fixing the issue, but if a JDK is not installed it looks like there will now just be a warning logged and the same error will be produced.
It would probably be worth it to just throw the Janino compilation call in a try block and produce a message that recommends turning on the option, as well as confirming the a JDK is available on all nodes running Drillbits. On Fri, Dec 4, 2015 at 11:41 AM, Jinfeng Ni <jinfengn...@gmail.com> wrote: > If JDK is not available, according to [1], there would be a warning in > drillbit.log. > > > [1] > https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/compile/JDKClassCompiler.java#L47 > > On Fri, Dec 4, 2015 at 11:11 AM, Jason Altekruse > <altekruseja...@gmail.com> wrote: > > Do we have something that checks a JDK is installed when launching Drill? > > Based on this JIRA it looks like we will fall back to janino if we cannot > > find a JDK. It is possible that this option does nothing if a JDK is not > > available, or it may fail with an error. We should test this out in > various > > environments and make sure that the action to take is clear in the > > exception messages. > > > > https://issues.apache.org/jira/browse/DRILL-1919 > > > > On Fri, Dec 4, 2015 at 11:01 AM, Jinfeng Ni <jinfengn...@gmail.com> > wrote: > > > >> You may consider switching the java_compiler from DEFALT to JDK, by : > >> > >> alter session set `exec.java_compiler` = 'JDK'; > >> > >> All Drill will automatically switch fro janino compiler to JDK, when > >> the source code length is beyond certain limit. If your query happens > >> to have smaller code than that limit, but still hit the limit for > >> janino compiler, then it's better to set the option to JDK. > >> > >> > >> > >> On Fri, Dec 4, 2015 at 10:48 AM, Jacques Nadeau <jacq...@dremio.com> > >> wrote: > >> > I'm guessing this is due to an extremely large number of columns, > >> > complicated expressions or extremely long column names. We test up to > a > >> > fairly large size here [1] but you may have exceeded what we test. Can > >> you > >> > share the query? > >> > > >> > [1] > >> > > >> > https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestLargeFileCompilation.java > >> > > >> > -- > >> > Jacques Nadeau > >> > CTO and Co-Founder, Dremio > >> > > >> > On Fri, Dec 4, 2015 at 9:33 AM, Abdel Hakim Deneche < > >> adene...@maprtech.com> > >> > wrote: > >> > > >> >> Hi Nirav, > >> >> > >> >> can you give us more information to help reproduce this issue ? > >> >> > >> >> thanks > >> >> > >> >> On Fri, Dec 4, 2015 at 3:42 AM, Nirav Shah <nirav.s...@games24x7.com > > > >> >> wrote: > >> >> > >> >> > Hello, > >> >> > > >> >> > I am getting below error while running big query. > >> >> > > >> >> > ======================================= > >> >> > > >> >> > Error: SYSTEM ERROR: CompileException: File > >> >> > > >> >> > >> > 'org.apache.drill.exec.compile.DrillJavaFileObject[ProjectorGen2825.java]', > >> >> > Line 5799, Column 17: ProjectorGen2825.java:5799: error: code too > >> large > >> >> > public void doEval(int inIndex, int outIndex) > >> >> > ^ (compiler.err.limit.code) > >> >> > > >> >> > > >> >> > Regards, > >> >> > Nirav > >> >> > > >> >> > >> >> > >> >> > >> >> -- > >> >> > >> >> Abdelhakim Deneche > >> >> > >> >> Software Engineer > >> >> > >> >> <http://www.mapr.com/> > >> >> > >> >> > >> >> Now Available - Free Hadoop On-Demand Training > >> >> < > >> >> > >> > http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available > >> >> > > >> >> > >> >
