Sounds great to me. So out of curiosity, if I'm checking out the source, is it better for me to get it from github.com, git.apache.org, or apache svn? It looks like JB checked in some changes when I look at the git.apache.org karaf-cellar repo, which I tried merging with my checkout from github. Git said I was up to date though. I tried checking out from svn and building and the build fails. Is the build still not working or is something wrong on my end? I just want to make sure that something isn't wrong on my end... I figured if JB checked some stuff in then it was probably working...
Ryan On Tue, Jan 22, 2013 at 3:33 AM, Achim Nierbeck <bcanh...@googlemail.com>wrote: > Great to hear, and as I already said we love Contributions :D > > Yeah those pull requests from Github don't really work out well with > projects hosted at Apache. > So Patches is much easier and afaik also better for IP clearances :) > > thanks and regards, Achim > > > 2013/1/22 Ryan Moquin <fragility...@gmail.com> > >> That's my intention :-) I did submit a couple the other day linked to >> Cellar pull requests regarding a discontinued Hazelcast component (JB >> already took care of that one), an issue with the version of the >> pax-mvn-url artifact and creating a kar for cellar as well as moving the >> config files around since when I build a custom Karaf archive, the cellar >> config files don't get put into the etc directory even though the features >> XML says they should be. So contributing as much as I can is certainly my >> intent. :-) >> >> Anyhow, pull requests are a pain in the rear to get setup with the >> correct changes.. I think I should just go back to creating patch files and >> attaching those. >> >> I'm hoping once JB has a chance to check-in I'll be able to make some >> more contributions, Cellar is a project that really interests me subject >> matter wise, so I like digging around in it when something doesn't go as >> planned. :-) >> >> Ryan >> On Jan 22, 2013 3:07 AM, "Achim Nierbeck" <bcanh...@googlemail.com> >> wrote: >> >>> Hi Ryan, >>> >>> it's always nice to have some code contribution. And even nicer if those >>> are attached to Jira Issues ;) >>> Would be great if you could add some of the missing pieces as patches to >>> jiras. >>> >>> >>> thanks, Achim >>> >>> >>> 2013/1/22 Ryan Moquin <fragility...@gmail.com> >>> >>>> Awesome, OK, I figured but I wanted to check since I hadn't seen any >>>> check ins yet. It was a good exercise in getting more familiar with the >>>> Cellar code, glad you already have it dealt with. >>>> >>>> I don't think I've seen that one yet, but I guess I'll find out. :-) >>>> >>>> No prob, when you check in those fixes I can move further on my usage >>>> of Cellar and see if I can fix anything that you haven't gotten to yet and >>>> submit. Thanks for your work on Cellar, can't wait to see it working with >>>> the other project I'm working. >>>> >>>> Thanks! >>>> >>>> Ryan >>>> On Jan 21, 2013 9:46 PM, "Jean-Baptiste Onofré" <j...@nanthrax.net> >>>> wrote: >>>> >>>>> Hi Ryan, >>>>> >>>>> I already fixed that on my local working copy. FYI, you may see an >>>>> issue with Cellar Features which "pollutes" the Karaf features service. >>>>> >>>>> For now, I'm focus on Cellar 2.3.x (fixes, itests, etc). I will commit >>>>> both on Cellar 2.3.x and Cellar trunk in the middle of this week. >>>>> >>>>> Regards >>>>> JB >>>>> >>>>> On 01/22/2013 03:43 AM, Ryan Moquin wrote: >>>>> >>>>>> I don't know if you are interested by my apache cellar fork has all >>>>>> the >>>>>> changes necessary to update the tests to use the apache karaf 3.0.0 >>>>>> commands which are different. I also added a group manager property >>>>>> in a >>>>>> couple blueprint files to prevent NPEs during startup. Unfortunately, >>>>>> even though those problems s are fixed, cellars 3.0.0 deadlocks during >>>>>> startup, one of the blocked threads seemed to be waiting on the "Karaf >>>>>> User Console" which didn't seem to make sense. When it doesn't >>>>>> deadlock, it will error out after a few seconds D's with concurrent >>>>>> modification exceptions due to the combined class loader being >>>>>> constantly requested to load a RemoteRepositoryEvent by simultaneous >>>>>> threads. When I hooked in a debugger, there were alternating >>>>>> RemoteRepositoryEvents saying the cellar feature repository was remove >>>>>> and added. They just kept rapidly firing and the console would show a >>>>>> concurrent modification except stack trace every few minutes. >>>>>> >>>>>> Unfortunately this looks .like it's going to be a pain in the but of a >>>>>> problem to fix.... have you seen that happen with Cellar 3.x yet? >>>>>> >>>>>> Ryan >>>>>> >>>>>> On Jan 16, 2013 10:54 AM, "Jean-Baptiste Onofré" <j...@nanthrax.net >>>>>> <mailto:j...@nanthrax.net>> wrote: >>>>>> >>>>>> Hi Ryan, >>>>>> >>>>>> yes, I started to work on both Cellar 2.3.x and trunk yesterday. >>>>>> It should be better by the end of this week. >>>>>> >>>>>> Regards >>>>>> JB >>>>>> >>>>>> On 01/16/2013 05:12 AM, Ryan Moquin wrote: >>>>>> >>>>>> I know I was told that this version isn't stable yet, but I >>>>>> still wanted >>>>>> to see if the build should be able to complete successfully or >>>>>> not. I >>>>>> want to determine if some issues I'm having are something on >>>>>> my >>>>>> end or >>>>>> not. Currently the itests always seem to fail with cellar >>>>>> trunk, is >>>>>> that the current known state of it? Or is it failing on my >>>>>> side >>>>>> only? >>>>>> >>>>>> Thanks, >>>>>> Ryan >>>>>> >>>>>> >>>>>> -- >>>>>> Jean-Baptiste Onofré >>>>>> jbono...@apache.org <mailto:jbono...@apache.org> >>>>>> http://blog.nanthrax.net >>>>>> Talend - http://www.talend.com >>>>>> >>>>>> >>>>> -- >>>>> Jean-Baptiste Onofré >>>>> jbono...@apache.org >>>>> http://blog.nanthrax.net >>>>> Talend - http://www.talend.com >>>>> >>>> >>> >>> >>> -- >>> >>> Apache Karaf <http://karaf.apache.org/> Committer & PMC >>> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer >>> & Project Lead >>> OPS4J Pax for Vaadin <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> >>> Commiter & Project Lead >>> blog <http://notizblog.nierbeck.de/> >>> >> > > > -- > > Apache Karaf <http://karaf.apache.org/> Committer & PMC > OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer & > Project Lead > OPS4J Pax for Vaadin <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> > Commiter & Project Lead > blog <http://notizblog.nierbeck.de/> >
