Jacques,
Which is a good idea? Hardcoding separator '-', or putting it in config folder like Scott said?
And will OFBiz receive this suggested change?
Please let me know, because I'm implementing it now. If my boss says he only ever needs '-', then
changing ProductFeatureServices.getVariantCombinations() is enough, I'm done. But I'd like to do
something that can be rolled into OFBiz.
For now, I'm maintaining the '-' separator change in my private branch of development, until OFBiz
accepts the change. That's that, I'm done. It's just a 1-second change, so if someone in charge of
commits can let me know "the right thing to do", I'll do it right away just so OFBiz can take in
my changes.
At risk of "asking for it (more work) for myself", would anyone want this separator to be
specify-able on the QuickAddVariants page/form itself?
Thanks!
Jonathon
Jacques Le Roux wrote:
Yes, sounds lilke a good idea indeed
Jacques
----- Original Message -----
From: "Scott Gray" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Friday, January 12, 2007 8:22 PM
Subject: Re: Suggested change to ProductFeatureServices.getVariantCombinations()
Hi Jonathan
I have done the same thing, I would say if any objected it could always
be added to one of the property files. Something like
product.variant.id.feature.separator=-
Jonathon -- Improov wrote:
Currently, that function appends the ProductFeature idCode(s)
immediately to the end of the Product ID. So, WG-9943 will have
WG-9943B3 rather than WG-9943-B3.
Can I just add a '-' before the entire string of ProductFeature
idCode(s)? Or should I do more work to store this prefix '-' in some
entity linked to a Product?
I'd like to have this feature rolled into OFBiz. Thanks!
Jonathon
