Re: CheckOutEvents setCheckOutPages

[Jacques Le Roux]

Stephen,

Feel free to open a Jira issue

Jacques

Scott Gray wrote:

Hi Stephen,

When I'm trying to figure this stuff out I usually refer to the revision 
history for the file to try and get an idea of where
things started to go wrong:

http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/CheckOutEvents.java?view=log

But it looks to me like CheckOutHelper.setCheckOutPayment(...) does its own 
validation so the if block you mention below does

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 29/01/2011, at 6:02 AM, Stephen Rufle wrote:

seem unnecessary.

In CheckOutEvents.setCheckOutPages(HttpServletRequest, HttpServletResponse)
the lines

Line 182
if (UtilValidate.isEmpty(selectedPaymentMethods)) {
return "error";
}

prevents a message from being shown
on the "3)How shall you pay?" step of checkout
https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/checkoutoptions

When "Continue to Final Order Review" is clicked, but nothing has been selected 
on the page.

If comment out the above lines I get "Please select a method of payment." which 
seems like the correct response. This issue

Should I create a JIRA issue and provide a patch, or am I missing something 
about the page flow?

exists in 10.04 and trunk.

smime.p7s
Description: S/MIME cryptographic signature