BTW, I vaguely remember a Jira and a patch have been created, should we review?
Thanks
Jacques
From: <c.schin...@googlemail.com>
Raj, Jacques,
Thanks for your suggestions. I have found a config error
I had taken over the _NA_ Tax Authority which was configured to add another 19
percent of VAT to my store prices.
Clearing this away helped.
Apologies for the long delay. It took a while :-)
Regards
Carsten
Gesendet mit BlackBerry® Webmail von Telekom Deutschland
-----Original Message-----
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
Date: Wed, 2 Feb 2011 10:52:53
To: <user@ofbiz.apache.org>
Reply-To: user@ofbiz.apache.org
Subject: Re: VAT is not applied for the shipping
To be more clear, what have changed in trunk is the possibilit to have prices
with VAT included and code was changed accordingly.
So the ProductPrice and OrderAdjustment entities have changed but not The
TaxAuthority data model, see
http://svn.apache.org/viewvc?view=revision&revision=1042542
IIRW there have been some code amendements after
Jacques
From: "Jacques Le Roux" <jacques.le.r...@les7arts.com>
It's the same in trunk
Jacques
From: "biletnikov" <biletni...@gmail.com>
Hello Paul,
thank you very much for your detailed explanation and solutions.
I think the first way is the more appropriate for us for the first time,
but I'm confused what we should do if we had in an order some items with
shippable tax and some with free shipping tax? Also the each our product
relates to the appropriate category.
Is this problem actual only for 9.04 release, or the current trunk has it
too?
Best regards,
Sergei
On Wed, Feb 2, 2011 at 8:57 AM, Paul Foxworthy [via OFBiz] <
ml-node+3253480-393799844-170...@n4.nabble.com<ml-node%2b3253480-393799844-170...@n4.nabble.com>
wrote:
Hi Sergei,
The trouble is that in the rateProductTaxCalc method, getTaxAdjustments is
called once per product, plus once for shipping and once for adjustments. In
trunk these are lines 218, 244 and 228 in
https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java?hb=true
When we call getTaxAdjustments for shipping and promotion, there's no
product, so the product category matching won't work. My change was to look
for rows with taxShipping of Y when there's no product.
If your shipping is always calculated for an order and not by individual
order items, you could set taxShipping to Y for one row in
TaxAuthorityRateProduct (TARP) and N for the others. A bit of a hack, but it
would work.
Another possibility is to define a new TAXABLE product category independent
of any other, so you only need one row in TARP. The problem with this is you
need to assign a product to the TAXABLE category as you create the product.
For me in Australia, pretty well everything is taxed, so most products would
need the category set.
A third way, again a hack, is to create a dummy product category that no
product has, and add a row to TARP with taxShipping of Y. All other TARP
rows would have taxShipping of N.
A better fix would need more consideration and more work.
Some possibilities I can think of:
- Add a new column to TARP, perhaps called something like taxRuleType or
taxScope. It would have values PRODUCT, SHIPPING, PROMOTION. You would add
separate rows for tax rules for shipping and promotion. Each of the three
calls to getTaxAdjustment would supply a parameter to say which taxRuleType
to search for.
- Define entirely separate entities for tax rules for shipping and
promotions rather than overload TARP
Cheers
Paul Foxworthy
------------------------------
If you reply to this email, your message will be added to the discussion
below:
http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-tp3234699p3253480.html
To unsubscribe from VAT is not applied for the shipping, click
here<http://ofbiz.135035.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=3234699&code=YmlsZXRuaWtvdkBnbWFpbC5jb218MzIzNDY5OXwyMDcwNzk3NDQ4>.
--
Best regards,
Sergei Biletnikov
--
View this message in context:
http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-tp3234699p3253536.html
Sent from the OFBiz - User mailing list archive at Nabble.com.
