Ingo, Thanks for clarifying, I would say it is fine to have these changes. If price is included in the tax then it should not be restricted to one type. So I think patch should be fine, and upon reviewing and working with change functionality we will be good to discuss it further.
Others in the community may have some different thoughts, but I think it should be fixed which ties the tax type with the feature completely. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> On Sat, Sep 12, 2020 at 3:15 PM Ingo Wolfmayr <ingo.wolfm...@wolfix.at> wrote: > Hi, > > what you are suggesting is how I setup my products and prices - that is > not a problem. The issue is, that using SALES_TAX with PRICE_INCLUDES_TAX = > Y does not work out of the box as I would expect it to, therefore I made > some changes on tax calculation on my side - that work for me and my > customers. I also tried to explane why I use prices with tax included ( > rounding issue). > > My real question was: Why is the calculated tax from a price with SALES > TAX included changed to VAT_TAX. > > If I sell a product for 5 Euros incl. Sales Tax to an end customer the > rusult in ofbiz will be: > > 4,55 net price > 0,45 VAT TAX > 5,00 gross price > > With all my examples I just wanted to show that I have the same customer, > same product with prices setup as net price (without tax included) the > result will look like: > > 4,55 net price > 0,45 SALES TAX > 5,00 gross price > > I assume that make sense for someone but I do not understand it by now. > Before I provide my changes as a proposal for a change I would like to be > sure if my changes make sense for the community. Otherwise I keep it in my > local repository. > > Best regards > Ingo > > -----Ursprüngliche Nachricht----- > Von: Rishi Solanki <rishisolan...@gmail.com> > Gesendet: Freitag, 11. September 2020 18:06 > An: ofbizuser <user@ofbiz.apache.org> > Betreff: Re: Sales Tax > > Exactly, what Ankush has suggested. That is why I try to simplify your > problem first. Additionally consider the product store group setting at > store level, and add two product price for each product with different > product store groups (in your case one price will be 4.55 where tax will be > calculated nad 5.00 where it won't be calculated). One for B2B and one for > B2C. And in result you will see the pricing based on your tax authority > setup which includes tax in price for one store and for another store it > adds tax after price. > > Hope that helps! > > Best Regards, > -- > Rishi Solanki > *CTO, Mindpath Technology* > Intelligent Solutions > cell: +91-98932-87847 > LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > > On Fri, Sep 11, 2020 at 4:49 PM Ankush Upadhyay < > ankush.upadh...@hotwaxsystems.com> wrote: > > > Hello Ingo, > > > > What I understand from your shared details, you have two stores for > > B2B and B2C and you want to show/calculate product pricing differently > > for both of them. > > To achieve this you have set up TaxAuthority and > > TaxAuthorityRateProducts for different categories. > > > > Did you try to set store wise pricing for your product's and set > > multiple TaxAuthority and TaxAuthorityRateProducts for price whether > > to include tax or not? > > > > > > Kind Regards, > > Ankush Upadhyay > > Senior Technical Consultant > > > > *HotWax Systems* > > *Enterprise open source experts* > > cell: +91-8109201285 > > office: 0731-409-3684 > > http://www.hotwaxsystems.com > > > > > > On Fri, Sep 11, 2020 at 12:43 PM Ingo Wolfmayr > > <ingo.wolfm...@wolfix.at> > > wrote: > > > > > Hello Rishi, > > > > > > basically yes. Usually the B2B price is different to the B2C price. > > > The problem was calculating the B2C price when prices have been > > > setup as net prices (without tax). Now and then you will have some > > > rounding > > inaccuracy - > > > having 5.01 instead of 5.00. Ofbiz is doing everthing right when > > > calculating from net price, but result is not satisfying. > > > > > > Best regards, > > > Ingo > > > > > > -----Ursprüngliche Nachricht----- > > > Von: Rishi Solanki <rishisolan...@gmail.com> > > > Gesendet: Donnerstag, 10. September 2020 23:23 > > > An: ofbizuser <user@ofbiz.apache.org> > > > Betreff: Re: Sales Tax > > > > > > Dear Ingo, > > > Here is my understanding of your problem. > > > > > > You have two stores as B2B and B2C. On B2C store you want show or > > > sale product with price and tax shown (that means 4.55 + 0.45). And > > > on B2B > > store > > > you want to sale on the same price that means 5.00 and it should not > > > show tax and as mentioned tax included in price. > > > > > > Am I correct? > > > > > > Best Regards, > > > -- > > > Rishi Solanki > > > *CTO, Mindpath Technology* > > > Intelligent Solutions > > > cell: +91-98932-87847 > > > LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > > > > > > > > On Mon, Sep 7, 2020 at 9:05 PM Ingo Wolfmayr > > > <ingo.wolfm...@wolfix.at> > > > wrote: > > > > > > > Hello, > > > > > > > > I have made a few changes to the price logic to get it working for > > > > my country (AUT - Europe) using Sales Tax and I have a question > > > > before I prepare a proposal patch for the community: > > > > > > > > My Setup: > > > > Tax Authority (PriceIncludesTax=Y) with three > > > > TaxAuthorityRateProducts > > > > - Sales tax 20 - assigned to product category mwst20 > > > > - Sales tax 10 - assigned to product category mwst10 > > > > - Sales tax 13 - assigned to product category mwst13 > > > > > > > > I created all product prices as gross price - setting > > > > "priceIncludesTax"="Y". The reason for that where some rounding > > > > issues (nothing to do with ofbiz). For example: I want to show the > > > > price to the customer as € 5,00 and not € 5,01. > > > > As I have customers that also have both B2C & B2B the b2b prices > > > > are setup as net prices (without tax) as they are shown in store > > > > without tax. So b2c customers nice looking prices (5,00, 5,99 …) > > > > and b2b > > > customer net prices. > > > > > > > > Here comes my question part: the default logic would change the > > > > tax type to VAT_TAX, if "priceIncludesTax" is in use - so > > > > SALES_TAX will be changed to VAT_TAX. From the logic I am > > > > following in my case the tax type should not changes whether the > > > > price has set up as gross-price > > > or net-price. > > > > I am selling my customer the product for 5 Euros including 10% tax. > > > > € 4,55 Net price > > > > € 0,45 Sales Tax > > > > € 5,00 Payed by customer > > > > > > > > If I setup the product price with 4,55 without tax the result > > > > should be the same. Is my logic interfering with some other logic > > > > that I am not aware by now and therefore it would not make any > > > > sense to make that work in standard ofbiz? > > > > > > > > Any thought on that would be welcome. > > > > > > > > Best regards, > > > > Ingo > > > > > > > > > > > > > >
