Hi Suraj, Here you are referring to the "storeOrder" service as we don't have a createSalesOrder service? I think this is not a good idea to add code regarding exploded items in storeOrder service, as its core service that creates the order based on given information. so if you pass the exploded items it will create order based on it.
Like in case of Checkout flow, CheckoutHelper checks and explodes items, so in case of API middleware should take care to explode items based on requirement. So I don't think it's a good idea to make it part of storeOrder service. Kind Regards, Deepak Dixit On Sat, Sep 26, 2020 at 1:47 PM Pradeep Chaudhary < pradeep.chaudh...@hotwaxsystems.com> wrote: > +1 for the approach. > > Hi Suraj, > > I agree with your points that explode item architecture helps the > businesses to easily manage the partial fulfillments and eliminates the > added overhead of complex calculations while fulfilling the > customer/business requirements. > > Supporting the 'explode item' feature at 'createSalesOrder' service will > help external systems to integrate with more flexibility. It will enable > them to choose a more appropriate approach ie. 'explode item' or regular as > per the business need. > > Best Regards, > > On Thu, Aug 6, 2020 at 4:23 PM Suraj Khurana <suraj.khur...@hotwax.co> > wrote: > > > Hello Pritam, > > > > Thanks for your reply. Yes, you are right, as I mentioned before, > > currently, OOTB OFBiz has this explode functionality on shopping cart > > level, that is using the same ProductStore.explodeOrderItems flag. > > > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Thu, Aug 6, 2020 at 10:54 AM Pritam Kute < > pritam.k...@hotwaxsystems.com > > > > > wrote: > > > > > Hello Suraj, > > > > > > This will be surely a good architecture for the businesses who route > > > shipments from different locations and allow partial returns etc. As > far > > as > > > I remember, there is one flag at the product store level with the name > > > "explodeOrderItems". When we set this flag to "Y", the system explodes > > > order items and create a separate order item data for multi-quantity > > items > > > in the order. I haven't tested it thoroughly but it works quite well on > > the > > > trunk code. > > > > > > Let's have others to comment on this. Also, let me know if you have > > > already tested this flow. > > > > > > Kind Regards, > > > -- > > > Pritam Kute > > > > > > > > > On Wed, Aug 5, 2020 at 9:02 PM Suraj Khurana <suraj.khur...@hotwax.co> > > > wrote: > > > > > >> Hello everyone, > > >> > > >> Hope everyone is safe and doing well. > > >> > > >> For any business which is supporting partial quantity cancellations or > > >> partial quantity fulfillments, then it can use exploding the order > item > > >> OOTB utility. > > >> > > >> - In case business is entertaining partial cancellations of items, > then > > >> all > > >> adjustments need to be re-calculated and prorated accordingly. This > > >> computation overhead can be avoided using an explode item while > creating > > >> an > > >> order. > > >> -- While doing this we also need to make sure that rounding is handled > > and > > >> the amount is adjusted properly between all order items. > > >> > > >> - In case of partial fulfillments, again business demands to prorate > > item > > >> adjustments (tax, shipping etc) to create a invoice, or if there is a > > >> third > > >> party accounting system in place, we need to provide respective data > to > > >> it, > > >> so again if you have already exploded the item while > importing/creating > > >> order into the system, you could have reduced this calculations > overhead > > >> and improve system performance in production environment. > > >> > > >> Currently, OOTB has this explode functionality on shopping cart level. > > >> IMO, we need to have the same capabilities in the createSalesOrder > > service > > >> (can be used as API call) as well. > > >> > > >> Please share your thoughts on this. Is there any other better approach > > to > > >> handle these business use cases? > > >> > > >> -- > > >> Best Regards, > > >> Suraj Khurana > > >> Senior Technical Consultant > > >> > > > > > > > > -- > Pradeep Choudhary > Senior Enterprise Software Engineer > > *HotWax Systems* > *Enterprise open source experts* > cell: +91-97527-20333 > office: 0731-409-3684 > http://www.hotwaxsystems.com >
