what I have already described in some detail. the use of base actions is a good 
pattern to use as one can group common behaviour into them, such as authentication or 
ensuring other properties. in our case we do both, security AND ensuring some session 
lists for user (i.e those things that make sense to be in session because they don't 
change often at all for the lifetime of a user's visit) but also request attributes as 
I said .. the user clicks a nav link, that page's attributes get loaded as a map, and 
do not make sense to be in the session because it is per-request object.

now, my issue with DynaActionForm is that it ought to relise that if it has to forward 
the user page to the page they came from, it ought to also forward the request values 
back, OR at least be able to give you the opportunity to specify an Action rather than 
an ActionForward as the input parameter so that we can ensure those request vars are 
present for the view.

managing a request attribute in the session by setting it and then making sure we pop 
it out at the view is messing and defies the semantic use of the request scope.

that's why it is bad practice.

ADC

> -----Original Message-----
> From: James Mitchell [mailto:[EMAIL PROTECTED]
> Sent: 17 September 2004 13:02
> To: Struts Users Mailing List
> Subject: Re: DynaActionForm and previous request attributes (no answer
> found in archives for similar problems)
> 
> 
> What is 'bad practice'?
> 
> 
> 
> --
> James Mitchell
> Software Engineer / Open Source Evangelist
> EdgeTech, Inc.
> 678.910.8017
> AIM: jmitchtx
> 
> ----- Original Message -----
> From: "Allistair Crossley" <[EMAIL PROTECTED]>
> To: "Struts Users Mailing List" <[EMAIL PROTECTED]>
> Sent: Friday, September 17, 2004 7:58 AM
> Subject: RE: DynaActionForm and previous request attributes 
> (no answer found
> in archives for similar problems)
> 
> 
> but that's bad practice. very bad.
> 
> > -----Original Message-----
> > From: Jitender K Chukkavenkata [mailto:[EMAIL PROTECTED]
> > Sent: 17 September 2004 12:51
> > To: Struts Users Mailing List
> > Subject: Re: DynaActionForm and previous request attributes 
> (no answer
> > found in archives for similar problems)
> >
> >
> > I would agree with him.  I can suggest you the same.
> >
> > Jitender Kumar C.V.
> >
> 
> 
> <FONT SIZE=1 FACE="VERDANA,ARIAL" COLOR=BLUE>
> -------------------------------------------------------
> QAS Ltd.
> Developers of QuickAddress Software
> <a href="http://www.qas.com";>www.qas.com</a>
> Registered in England: No 2582055
> Registered in Australia: No 082 851 474
> -------------------------------------------------------
> </FONT>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to