Hey J?rg, Thanks for the note about enums, I had it in my head that enum's have been in java like that since 1.0. This explains why so many APIs inside java are using int constants.
Anyways, my todos: * revert the method signatures to maintain binary compatibility. This means I have to use a cast in a couple places but I think its a pretty safe one (ie, I'm not sure theres a flow where the XPathStrategy can return a marshaller that isn't a XPathMarshaller). * I'll remove the enums and use static integers (maybe with an odd range of numbers so-as to allow for an assertion that the caller used the proper integers) And of course when I send you any diffs I'll remove the class files --that was simply me bashing your build system into a repo that I didn't really spend much time setting up. I just wanted a concise list of the diffs, which a github pull-request provides. Cheers, -Geoff Sent from Windows Mail From: J?rg Schaible<mailto:joerg.schai...@swisspost.com> Sent: ?Monday?, ?April? ?27?, ?2015 ?4?:?46? ?AM To: user@xstream.codehaus.org<mailto:user@xstream.codehaus.org> Hi Geoff, sorry for being silent, but we're busy getting several projects out of the Haus before it shuts down. Geoff Groos wrote: > Hey guys, > > So I whipped together this quick patch: > https://github.com/Groostav/XStream-GG/pull/1 > > I think I'd like to modify it to remove the `Context` object --its too big > a klooge to have the configuration need to know if the caller is > Unmarshalling or Marshalling. I'll get around to that today. > > let me know what you think. I had a short look at the diffs. Actually they should not contain any cruft (.class files, ...). For the implementation: I would have used the Mapper interface also as "entry" point. However, you may not modify a method, you have to add a new one instead (resp. overload a method) to keep binary compatibility. The master branch is already for XStream 1.5.x with a minimum requirement of Java 6. However, I assume, you're interested in getting this into the 1.4.x branch (Java 1.4.x compatible). Therefore you cannot use a Java enum at all, we cannot backport it. Basically all you need is a boolean flag for the immutable types that do not support references at all. We have no intentions to support multiple modes here, it's just a compatibility helper. Thanks for your effort so far, J?rg --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email