(Adding in Alan Burlison for Perl advice here - Craig is out today):

On 10/31/11 08:33 AM, Danek Duvall wrote:
Rich Burridge wrote:

   http://jurassic.us.oracle.com/~richb/7071875-v1/

Works for me.

I think that cf_by probably needs to change, too, but I'm not sure what to.
Maybe the same as cf_email?

I did a grep for cf_by in all the perl 5.12 files and it appears to be used by:

/usr/perl5/5.12/bin/perlbug
/usr/perl5/5.12/bin/perlthanks

and also present in

/usr/perl5/5.12/lib/i86pc-solaris-64int/Config_heavy.pl:cf_by='perl-bugs'
/usr/perl5/5.12/lib/i86pc-solaris-64int/Config_heavy.pl:config_arg13='-Dcf_by=perl-bugs'
/usr/perl5/5.12/lib/i86pc-solaris-64int/Config_heavy.pl:config_args='-Dprefix=/usr/perl5/5.12 -Dprivlib=/usr/perl5/5.12/lib -Dsitelib=/usr/perl/site_perl/5.12 -Dvendorprefix=/usr/perl5/5.12 -Dvendorlib=/usr/perl5/vendor_perl/5.12 -Dlibperl=libperl.so -Duseshrplib -Dusedtrace -Duse64bitint -Dcc=cc -Doptimize=-xO4 [email protected] -Dcf_by=perl-bugs -Dmyhostname=localhost -O -de'
/usr/perl5/5.12/lib/i86pc-solaris-64int/Config.pod:=item C<cf_by>
/usr/perl5/5.12/lib/pod/perltoc.pod:C<ccflags_uselargefiles>, C<ccname>, C<ccsymbols>, 
C<ccversion>, C<cf_by>,
/usr/perl5/5.12/man/man1/perltoc.1:\&\f(CW\*(C`ccflags_uselargefiles\*(C'\fR, \f(CW\*(C`ccname\*(C'\fR, \f(CW\*(C`ccsymbols\*(C'\fR, \f(CW\*(C`ccversion\*(C'\fR, \f(CW\*(C`cf_by\*(C'\fR,
/usr/perl5/5.12/man/man3/Config.3:.ie n .IP """cf_by""" 4
/usr/perl5/5.12/man/man3/Config.3:.el .IP "\f(CWcf_by\fR" 4
/usr/perl5/5.12/man/man3/Config.3:.IX Item "cf_by"


My Perl-fu is virtually non-existent, so I'm going to need some guidance here,
but my feeling is it's a "read-only" variable rather than something that we need
to adjust in order to get email to the correct location.

Thanks for the review.



--- Begin Message ---
Hi,

Could I please get a code review for my fix for:

  7071875 perl 5.12 -V output has a sun.com email address
  http://monaco.us.oracle.com/detail.jsf?cr=7071875

Webrev is at:

  http://jurassic.us.oracle.com/~richb/7071875-v1/

x86 Workspace (with just the component in question built) is at:

  /net/stard.us.oracle.com/tank/ws/UL/7071875/

(The configure/build/install/publish transcript is in a file called
'publish-trans.txt' in the component directory).

See the Bugster CR for more details.

Thanks.


--- End Message ---
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to