On 11/10/2011 11:48 AM, Danek Duvall wrote:
Rich Burridge wrote:
http://jurassic.us.oracle.com/~richb/7085723-v1/
Most of this is fine. But for the components which do more than simply set
human-version to $(COMPONENT_VERSION), I'd rather see something similar to
what you did for aalib -- define a HUMAN_VERSION macro, and build it up in
the Makefile, rather than in the manifest. So, for imagemagick:
Makefile:
HUMAN_VERSION=$(COMPONENT_VERSION)-$(COMPONENT_SUBVERSION)
PKG_MACROS += HUMAN_VERSION=$(HUMAN_VERSION)
imagemagick.p5m:
set name=pkg.human-version value=$(HUMAN_VERSION)
In fact, you could probably just put HUMAN_VERSION into PKG_MACROS up in
ips.mk. I think the others are ntp, proftpd, and slrn.
Okay. So changed. New webrev is at:
http://jurassic.us.oracle.com/~richb/7085723-v2/
I've also added in the human version change per Alan's suggestion.
Thanks to you both.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
