----- [email protected] wrote:
> I'm requesting a code review for the cmake upgrade to v2.8.6.
>
> Webrev:
> http://jurassic.us.oracle.com/net/sfwcfi/builds/ac9715/cmake-upgrade/webrev-1/
>
components/cmake/cmake.license
6 ------------
7 CMAKE v8.6.2
8 ------------
I think you reversed the version.
1 Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
2
3 This package may include technology which may be subject to one or more of
the
4 following additional notices:
I'm not up to date on the latest rules but putting an Oracle copyright
in the license file just seems wrong.
There's enough changes to the license file that you will probably
need a full legal review.
> I did not commit the changes yet, so the webrev doesn't include
> links to the bugs and PSARC case. The relevant PSARC case and bugids
> are:
>
> PSARC/2011/354 Update Cmake to 2.8.6
> http://psarc/Archives/CaseLog/arc/PSARC/2011/354/
>
> 6892526 cmake upgrade to v2.8.6
> http://monaco.us.oracle.com/detail.jsf?cr=6892526
Please put a code diff in the suggested fix field.
>
> 7085602 cmake needs license file update
> http://monaco.us.oracle.com/detail.jsf?cr=7085602
Please put a code diff in the suggested fix field.
Don't forget to review 3psc if it needs resubmitting.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
