Thanks, Kevin! I'm checking on the copyright.
April
On 12/ 1/11 12:21 PM, Kevin Crowe wrote:
Hey Craig, April, just a couple notes in-line below:
On 12/ 1/11 02:37 PM, Craig Mohrman wrote:
----- [email protected] wrote:
I'm requesting a code review for the cmake upgrade to v2.8.6.
Webrev:
http://jurassic.us.oracle.com/net/sfwcfi/builds/ac9715/cmake-upgrade/webrev-1/
components/cmake/cmake.license
6 ------------
7 CMAKE v8.6.2
8 ------------
I think you reversed the version.
1 Copyright (c) 2011, Oracle and/or its affiliates. All rights
reserved.
2
3 This package may include technology which may be subject to one
or more of the
4 following additional notices:
I'm not up to date on the latest rules but putting an
Oracle copyright
in the license file just seems wrong.
I agree, as it was explained to me we only have the Oracle copyright
on components that contain code Oracle wrote. (how much code?
upstream? our original code? I dunno, when you get one of these all I
can suggest is to check with legal.)
Also lines 3 & 4 above can be deleted. I'm told those are only
necessary if a package contains multiple 'components' with different
licenses in it. I was looking for an example of one in Userland but I
couldn't find one so I could not make an example of it to verify with
legal.
There's enough changes to the license file that you will probably
need a full legal review.
That's only for a 'license change or use case change' (per cteam
yesterday). All the changes in the license file that I see are those
same changes requested by legal in the tool for tracking number 6581
so I think they are good (says the man that doesn't have one of his
own components license files updated in the gate yet...) Anyways, if
you check out 6581 in the Legal Review tab for "Attribution
Requirement Note" it looks like what April has in there so I think
that part is good.
Hope that helps,
Thanks,
Kevin.
I did not commit the changes yet, so the webrev doesn't include
links to the bugs and PSARC case. The relevant PSARC case and bugids
are:
PSARC/2011/354 Update Cmake to 2.8.6
http://psarc/Archives/CaseLog/arc/PSARC/2011/354/
6892526 cmake upgrade to v2.8.6
http://monaco.us.oracle.com/detail.jsf?cr=6892526
Please put a code diff in the suggested fix field.
7085602 cmake needs license file update
http://monaco.us.oracle.com/detail.jsf?cr=7085602
Please put a code diff in the suggested fix field.
Don't forget to review 3psc if it needs resubmitting.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
