Thanks for looking at this.
On 12/14/11 16:28, Danek Duvall wrote:
Brian Utterback wrote:
http://jurassic.us.oracle.com/net/drosera.us.oracle.com/export/users/blu/scratch/ul/ul-quagga-update/webrev/
Looks good, though not being a subject expert, I skimmed most of the diffs
of diffs, noticing only a couple of nits ...
65-isisd-iso-checksum.patch:
- line 76: "propagated"
Fixed
- You should probably be more consistent about closing tags having a
space before them: "<propval ... value='' />" rather than"<propval ...
value=''/>".
Fixed.
70-isid-trill.patch:
- Looks like you regenerated the patch without the -p flag to diff, which
can be very handy for anyone maintaining it.
I can't find anything about a "-p" flag to diff. Please explain?
There is a new patch that represents the output of automake and
autoconf because Solaris does not currently support the required
versions of those packages to allow them to be run as part of the
build process. Once a newer version of automake and autoconf are
integrated, this patch can be removed.
That information should be kept somewhere -- either in the header of the
patch (my preference) or in the bug that introduced it. In general, I
think patches should have some sort of explanation associated with them,
to help future maintainers grok what's going on.
Danek
I think that gpatch will ignore leading junk. Do you happen to know of a
format that will work for adding a comment to the beginning of a patch?
New webrev at:
http://jurassic.us.oracle.com/net/drosera.us.oracle.com/export/users/blu/scratch/ul/ul-quagga-update/webrev/
--
blu
Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live. - Martin Golding
-----------------------------------------------------------------------|
Brian Utterback - Solaris RPE, Oracle Corporation.
Ph:603-262-3916, Em:[email protected]
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
