On 12/16/11 15:35, Danek Duvall wrote:
Brian Utterback wrote:
70-isid-trill.patch:
- Looks like you regenerated the patch without the -p flag to diff, which
can be very handy for anyone maintaining it.
I can't find anything about a "-p" flag to diff. Please explain?
GNU diff. It's what prints the name of the function after the hunk header.
You can see that disappearing in your diffs. Presumably whoever generated
those diffs before used GNU diff, and included the -p flag.
Ah, I see. I'd prefer to not regen it all now, but I will certainly use
the -p flag in the furture.
I think that gpatch will ignore leading junk. Do you happen to know of a
format that will work for adding a comment to the beginning of a patch?
Anything you want. Patch will skip lines until it finds a patch header.
Great.
http://jurassic.us.oracle.com/net/drosera.us.oracle.com/export/users/blu/scratch/ul/ul-quagga-update/webrev/
For something this size, it'd be useful to have an incremental webrev, but
it looks like you've addressed what you said you did. :)
Thanks,
Danek
You're right, it didn't occur to me. Sorry.
--
blu
Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live. - Martin Golding
-----------------------------------------------------------------------|
Brian Utterback - Solaris RPE, Oracle Corporation.
Ph:603-262-3916, Em:[email protected]
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
