Hi,
Could I please get a code review for my fix for:
6857103 tclsh should use 64bit binary on 64bit systems
http://monaco.us.oracle.com/detail.jsf?cr=6857103
Webrev is at:
http://jurassic.us.oracle.com/~richb/6857103-v1/
x86 workspace (with tcl built) is at:
/net/stard.us.oracle.com/tank/ws/UL/6857103/
Configure/build/install/publish transcript at:
/net/stard.us.oracle.com/tank/ws/UL/6857103/components/tcl/tcl/publish-trans.txt
There are several ways this could be changed. I took the approach
found in the top.p5m file.
Alan Coopersmith also suggested:
"My quick guess at the cleanest fix would be to move the 32-bit
version to the
i86 subdirectory and then make /usr/bin/tclsh8.5 a link to amd64/tclsh8.5
or sparcv9/tcls8.5. (I'm guessing there are times you might want the
32-bit
version, especially if you have loadable .so modules that may be
loaded for
extensions that haven't been ported to 64-bit yet. Otherwise you'd just
drop the 32-bit and move the 64-bit into the main directory, like we
did with
the Xorg binary after the 32-bit EOF.) "
If either of those two solutions is the preferred one, let me know
and I'll adjust accordingly.
See the Bugster CR for more details.
(Note I haven't updated the bug report yet until we have reached a
concensus on the best way of fixing this.)
Tested with:
$ sudo pkg set-publisher -p file:///tank/ws/UL/6857103/i386/repo
$ sudo beadm create test-6857103
$ sudo beadm mount test-6857103 /mnt
$ sudo pkg -R /mnt uninstall pkg://solaris/entire
$ sudo pkg -R /mnt uninstall
pkg://solaris/consolidation/userland/userland-incorporation
$ sudo pkg -R /mnt install pkg://userland/runtime/tcl-8
and then checking that the tclsh[8.5] binaries and links are correct.
That BE is currently still mounted on stard.us.oracle.com if anybody
wants to take a look.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
