Hi Rich,
Thanks for code reviewing!
See my comments below.
The webrev of diffs since the last version is:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-upgrade/webrev-3-diffs/
The full webrev is:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-upgrade/webrev-3/
Thanks,
April
On 03/ 7/12 03:52 PM, Rich Burridge wrote:
On 03/07/2012 02:11 PM, April Chin wrote:
Argggh...sorry, here is the webrev:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/pcre-upgrade/webrev-1/
.../components/pcre/Solaris/fix-manpages
75 /usr/bin/sed -e "s/^\.TH \{1,\}[^ ]\{1,\} \{1,\}[1-9][^
]* *$/& \"${MOD_DATE}\" \"PCRE ${VER}\"/" ${FILE}> ${TMPFILE}
76 /usr/bin/mv -f ${TMPFILE} ${FILE}
If you use /usr/gnu/bin/sed -i, you don't have to use a temporary file
and then move it into place (which personally I think is nicer).
I didn't know about GNU sed's -i option. Thanks, I'll use that.
.../components/pcre/pcre.license
Is there no TPNO for this component? It looks like it's 7692.
From my discussions with Fred today, I think it's safe to add this
to the license file now, even though we haven't got final approval yet.
As far as I can tell, there is no TPNO for pcre, at least not for the
Solaris use of pcre for
the SARF forms I submitted.
TPNO 7692 says it's for pcre version 8.2.1, not v8.21. None of the
other fields are filled in,
so I can't tell much about this entry.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
