Hey Rich,
I see nothing wrong with your changes - except areca probably needs an
update, see below:
-TPNO#'s look right
-nothing added/changed that looks incorrect
-your one change to a .p5m file looks good, etc.
That being said I've noted the minor diffs from your license text
changes compared to whats in the tracking tool. I'd even argue that
your non-changes are typically better (wrapped lines, blank lines vs the
tool that did not wrap lines or were missing blank lines in some cases,
etc.) Still, I noted the diffs just for the sake of being thorough.
If you update areca (or ping legal on it?) I'd give these changes a
thumbs up, the rest is your call.
Thanks,
Kevin.
areca:
-note that the license tool has this for the first 2 lines:
Copyright 2005-2009, Olivier PETRUCCI.
This program is distributed under the GNU General Public License v2.
while the first 2 lines of the license are:
Copyright 2005-2009, Olivier PETRUCCI <aven...@users.sourceforge.net>
{ a blank line, no actual text }
-also, address has changed, the license tool has the new address (
http://www.fsf.org/about/contact/ ):
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
while the license file has the old address:
675 Mass Ave, Cambridge, MA 02139, USA
and the address differs again further down in the license file. If there
are other minor differences I do not see them.
autogen:
-matches what is in the license tool.
ilmbase:
-Looks like the license tool has the first line as:
OPENEXR:
Otherwise the license file matches what is in the license tool.
iperf:
-matches what is in the license tool.
libmng:
-the license tool Attribution Requirement Note does not have the long
/*******/
header and footer lines.
Otherwise the license file matches what is in the license tool.
libxml2:
-license tool does not include a blank line where the license file has one
at line 29. Otherwise the license file matches what is in the license
tool.
libxslt:
-matches what is in the license tool.
lighttpd:
-matches what is in the license tool.
lua:
-The license tool Attribution Requirement Note does not seem to have blank
lines and has no wrapping of text at 80-ish characters as might be
expected.
Otherwise the text seems to match.
openexr:
-Looks like the license tool has the first line as:
OPENEXR:
Otherwise the license file matches what is in the license tool.
swig:
-matches what is in the license tool.
tcpdump:
-matches what is in the license tool.
On 03/ 7/12 04:15 PM, Rich Burridge wrote:
Hi all,
Could I please get a code review for:
7085609 openexr and ilmbase need license file upgrade
http://monaco.us.oracle.com/detail.jsf?cr=7085609
7085613 libmng needs license file upgrade
http://monaco.us.oracle.com/detail.jsf?cr=7085613
7085624 lighttpd needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7085624
7085966 iperf needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7085966
7085948 swig needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7085948
7085963 tcpdump needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7085963
7085967 Lua needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7085967
7123118 libxslt needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7123118
7123119 libxml2 needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7123119
7133262 areca needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7133262
7151922 autogen needs TPNO and license file modifications
http://monaco.us.oracle.com/detail.jsf?cr=7151922
Webrev is at:
http://jurassic.sfbay/~richb/TPNO_changes-v1/
Userland workspace is at:
/net/stard.us.oracle.com/tank/ws/UL/TPNO_changes/
There is a build/publish log called 'publish-trans.txt' in each
component directory that changed.
Alert viewers will note that all of these entries in the Oracle Third
Party tracking tool are currently in a pending approval state. I spoke
with Fred on this. He said it's fine to add the TPNO # etc to the
license file even though the approval is pending.
Thanks.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
