Rich Burridge wrote: > Hi, > > Could I please get a code review for the changes for: > > 7164355 Parfait problem with aalib > http://monaco.us.oracle.com/detail.jsf?cr=7164355
Given how many false positives I saw running parfait on vim, I'd like to see some evaluation in the bug about how you determined that this was a real problem. When you did your testing, did you see the file descriptor leak prior to adding the fix, and see that it went away afterwards, or was your test simply that aasavefont didn't break? The fix looks fine, if unnecessary, since the descriptor will be closed anyway, on program exit. Seems like parfait could learn to be a bit sloppy here. Danek _______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
