On 05/ 1/12 11:13 AM, Danek Duvall wrote:
Rich Burridge wrote:
Hi,
Could I please get a code review for the changes for:
7164355 Parfait problem with aalib
http://monaco.us.oracle.com/detail.jsf?cr=7164355
Given how many false positives I saw running parfait on vim, I'd like to
see some evaluation in the bug about how you determined that this was a
real problem.
In this case, i's not a real problem (see below). I thought the goal here
was to make our code Parfait clean.
When you did your testing, did you see the file descriptor leak prior to
adding the fix, and see that it went away afterwards, or was your test
simply that aasavefont didn't break?
You answered your own question with the comment below. The file
descriptor will be automatically closed as the program exits. Parfait
doesn't appear to have the smarts to understand that and deal accordingly.
The fix looks fine, if unnecessary, since the descriptor will be closed
anyway, on program exit. Seems like parfait could learn to be a bit sloppy
here.
Agreed.
Danek
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
