Rich Burridge wrote:

>   http://jurassic.us.oracle.com/~richb/7164360-v1/

The return type of get_download_ses() is "struct session *", not "struct
terminal *", so in addition to your new variables being oddly named, I'm
surprised the compiler didn't at least whine about the type.  You get
unlucky in that both structures have a "term" member, but they're of
completely different types, so I'd expect bad behavior from msg_box().

I also suspect that this is a false positive, but I expect only the links
folks would be willing to track it down for sure.  That said, if it is a
real problem, I wonder what the ramifications are of not calling msg_box().
Do we simply fail to display a message and nothing more?

I'm also not sure how to trigger the other fix (in view.c), but the fix
looks fine to shut parfait up.

Thanks,
Danek
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to