On 05/ 7/12 03:15 PM, Danek Duvall wrote:
Rich Burridge wrote:
http://jurassic.us.oracle.com/~richb/7164360-v1/
The return type of get_download_ses() is "struct session *", not "struct
terminal *", so in addition to your new variables being oddly named, I'm
surprised the compiler didn't at least whine about the type.
Oh it did, but the Solaris cc compiler was whining about *so many*
other potential problems with the links code that I didn't notice it.
See:
/net/stard.us.oracle.com/tank/ws/UL/7164360/components/links/publish-trans.txt
The problem is a vestige of an earlier attempt to fix the parfait errors in a
different way.
I've now fixed them correctly. New webrev at:
http://jurassic.us.oracle.com/~richb/7164360-v2/
I also suspect that this is a false positive, but I expect only the links
folks would be willing to track it down for sure. That said, if it is a
real problem, I wonder what the ramifications are of not calling msg_box().
Do we simply fail to display a message and nothing more?
Correct. Better that than a core dump from a dereferenced pointer.
My suspicion is that the situation is rare though.
I'm also not sure how to trigger the other fix (in view.c), but the fix
looks fine to shut parfait up.
Okay.
Thanks.
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
