Hi Craig,
Here's a few comments so far.
April
components/php-5_2/apache-php5.p5m:
- Might put a comment here saying this is
Legacy package information for renamed apache-php52 package.
components/php-5_2/apache-php52.p5m:
- I don't really know how this works when a writable file has been moved
from one package (SUNWapch22-php52) to another
(web/server/apache-22/module/apache-php5), and then to another
(this apache-php52 package). Do we need to note the 2nd pkg move
as well somehow?
45 file path=etc/apache2/2.2/conf.d/php/php5.2.conf mode=0644 \
46
original_name=SUNWapch22-php52:etc/apache2/2.2/conf.d/php5.2.conf \
47 preserve=renamenew
- Does this link need to be mediated, depending on the php version?
Or is it only intended to link to mod_php5.2.so? See comments for
apache-php53.p5m.
link path=usr/apache2/2.2/libexec/mod_php5.so target=mod_php5.2.so
components/php-5_3/apache-php53.p5m:
- Missing this entry:
dir path=etc/apache2/2.2/conf.d
- Do we need to add this mediated link entry? The latest changes to the
PSARC/2012/067 case don't mention mod_php5.so anymore,
so I'm not sure if the link is only intended for mod_php5.2.so (it's
in apache-php52.p5m) or for mod_php5.3.so as well.
link path=usr/apache2/2.2/libexec/mod_php5.so target=mod_php5.3.so
mediator=php mediator-version=5.3
components/php-common/php.conf:
- "has change" -> "has changed"
# The configuration of PHP has change since Solaris 11 so any existing
- "pkg(1)" -> "(see pkg(1))" ?
# /etc/apache2/2.2/conf.d/php/php.conf is an IPS mediated link pkg(1) to
# the real Apache configuration file for PHP.
On 05/14/12 10:42 AM, Craig Mohrman wrote:
Ok.
Lots has changed since this first round of code review.
First the PSARC has a +1 so the architecture changes should be set.
I'll respond to all 3 of April's emails plus there's
a new package, php-common, which holds common components.
Namely a generic man page and a configuration file.
The full new webrev is here:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_php-5_3_10/webrev/
The delta webrev including April's comments and new stuff is here:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_php-5_3_10/webrev-delta-r2/
Plus compare these files manually for something more meaningful besides NEW:
cd /net/mogo.us.oracle.com/builds3/cmohrman/userland_php-5_3_10/components
{DIFF} php-5_2/apache-php52.p5m php-5_3/apache-php53.p5m
{DIFF} php-5_2/apache-php52.license php-5_3/apache-php53.license
Thanks,
craig
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
