----- april.c...@oracle.com wrote: > Thanks, Craig. I checked your workspace for the changes below, > and they look fine to me, except for the open question to IPS folks > on the renamed packages for components/php-5_2/apache-php52.p5m. > > I've checked out the other changes in the webrev diff and I have only > > one more > comment. > > components/php-5_2/php-52.p5m: > - Can remove the mode=0555, since it's the default > mode for .*bin/.* files in transforms/defaults > > 135 file path=usr/php/5.2/bin/php-config mode=0555 >
Done. Thanks much April. craig > The rest looks fine to me. > > April > > On 05/15/12 02:59 PM, Craig Mohrman wrote: > > ----- april.c...@oracle.com wrote: > > > >> Hi Craig, > >> > >> Here's a few comments so far. > >> > >> April > >> > >> components/php-5_2/apache-php5.p5m: > >> > >> - Might put a comment here saying this is > >> Legacy package information for renamed apache-php52 package. > >> > > Done. > > > > > >> components/php-5_2/apache-php52.p5m: > >> > >> - I don't really know how this works when a writable file has been > >> moved > >> from one package (SUNWapch22-php52) to another > >> (web/server/apache-22/module/apache-php5), and then to another > >> (this apache-php52 package). Do we need to note the 2nd pkg > move > >> as well somehow? > >> 45 file path=etc/apache2/2.2/conf.d/php/php5.2.conf mode=0644 > \ > >> 46 > >> original_name=SUNWapch22-php52:etc/apache2/2.2/conf.d/php5.2.conf > \ > >> 47 preserve=renamenew > >> > > Don't know. > > That's one of the reasons I've requested a separate IPS review. > > > > > >> - Does this link need to be mediated, depending on the php > version? > >> Or is it only intended to link to mod_php5.2.so? See comments > for > >> apache-php53.p5m. > >> link path=usr/apache2/2.2/libexec/mod_php5.so target=mod_php5.2.so > >> > > No. > > But I'm leaving the link behind for legacy reasons. > > A user's existing php5.2.conf file could very well reference > mod_php5.so > > because that's how we shipped the default php5.2.conf file. > > From now on php*.conf files will reference the exact .so they > need. > > I didn't find mod_php5.so adds value. > > > > > >> components/php-5_3/apache-php53.p5m: > >> > >> - Missing this entry: > >> dir path=etc/apache2/2.2/conf.d > >> > > Fixed. > > > > > >> - Do we need to add this mediated link entry? The latest changes > to > >> the > >> PSARC/2012/067 case don't mention mod_php5.so anymore, > >> so I'm not sure if the link is only intended for mod_php5.2.so > >> (it's > >> in apache-php52.p5m) or for mod_php5.3.so as well. > >> > >> link path=usr/apache2/2.2/libexec/mod_php5.so target=mod_php5.3.so > >> mediator=php mediator-version=5.3 > >> > > No. See above. > > > > > >> components/php-common/php.conf: > >> > >> - "has change" -> "has changed" > >> # The configuration of PHP has change since Solaris 11 so any > >> existing > >> > > Fixed. > > > > > >> - "pkg(1)" -> "(see pkg(1))" ? > >> # /etc/apache2/2.2/conf.d/php/php.conf is an IPS mediated link > pkg(1) > >> to > >> # the real Apache configuration file for PHP. > > Fixed. > > > > Thanks April. > > craig _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
