I'll give you feedback on the userland generic stuff.
Don't know about the command completions.
components/zsh/Makefile
Can simplify this:
59 sed -e 's,-L/usr/lib -R/usr/lib,,' \
60 config.status > config.status.new; \
61 mv config.status.new config.status; \
62 chmod 755 config.status; \
To:
$(GSED) -i -e 's,-L/usr/lib -R/usr/lib,,' \
config.status > config.status.new;
$(CHMOD) 755 config.status; \
and you don't need line 61.
gsed inplace editing.
I'll be upgrading gawk to 3.1.8 in build 18.
Does that help lines 73-76?
components/zsh/Completion/Solaris/Command/_svcprop:
Just out of curiosity why does this NEW file already have a package
manifest entry while _beadm does not?
components/zsh/patches/4500760.patch
No issues.
That's it for me.
craig
----- [email protected] wrote:
> Here's a code review for the latest zsh version:
>
>
> https://cr.opensolaris.org/action/browse/userland/dduvall/zsh-4.3.17
>
> Included are some completion updates, and a fix for a long-standing
> bug.
>
> Note that _svccfg and _svcprop aren't new; this is simply the first
> time
> they've been updated since their inclusion in the zsh tarball. The
> diffs
> against the tarball version are here:
>
>
> https://cr.opensolaris.org/action/browse/userland/dduvall/zsh-4.3.17/_svccfg.diff
>
> https://cr.opensolaris.org/action/browse/userland/dduvall/zsh-4.3.17/_svcprop.diff
>
> Thanks,
> Danek
> _______________________________________________
> userland-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
