Craig Mohrman wrote: > I'll give you feedback on the userland generic stuff. > Don't know about the command completions. > > components/zsh/Makefile > Can simplify this: > 59 sed -e 's,-L/usr/lib -R/usr/lib,,' \ > 60 config.status > config.status.new; \ > 61 mv config.status.new config.status; \ > 62 chmod 755 config.status; \ > > To: > $(GSED) -i -e 's,-L/usr/lib -R/usr/lib,,' \ > config.status > config.status.new; > $(CHMOD) 755 config.status; \ > > and you don't need line 61. > gsed inplace editing. > > I'll be upgrading gawk to 3.1.8 in build 18. > Does that help lines 73-76?
I dunno. Once we're building on 18, I'll test it out and see. :) I'll leave the sed change until then, too, since that I'm not touching it otherwise now. > components/zsh/Completion/Solaris/Command/_svcprop: > Just out of curiosity why does this NEW file already have a package > manifest entry while _beadm does not? Some of the completion functions, including _svcprop, are already distributed with the zsh source. Rather than patching them, I maintain their updates as whole files and copy them into place. Those have been in the package for a while, but only now are getting changes applied, so they're already in the manifest, but new in the gate. In the case of _beadm, it isn't in the source distribution yet, and so we see not only an addition to the gate but to the manifest as well. Thanks, Danek _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
