On 07/24/12 08:46 AM, Craig Mohrman wrote:
Second request.
Anyone?
You say below that you "Took a very minimal/conservative approach to these
changes since it's so late in the release" but if you put the COMPONENT_VERSION
in your php-5_3 Makefile, then wouldn't you be able to replace things like:
-set name=pkg.fmri value=pkg:/web/[email protected],$(BUILD_VERSION)
+set name=pkg.fmri value=pkg:/web/[email protected],$(BUILD_VERSION)
with:
-set name=pkg.fmri value=pkg:/web/[email protected],$(BUILD_VERSION)
+set name=pkg.fmri value=pkg:/web/php-53@$(COMPONENT_VERSION),$(BUILD_VERSION)
and next time you update you wouldn't need to change the line at all?
(There are a lot of similar changes you could make to minimize the work you
need to do in future, and the additional changes you would need to make
now are minimal).
----- [email protected] wrote:
I know. I know.
I just putback a new php in build 18.
But hey. That's already stale.
More security threats and some core dumps are fixed
by this.
Took a very minimal/conservative approach to these
changes since it's so late in the release.
I would appreciate a code review:
http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_php-7177478/webrev/
Don't be offended, yet, by the static version numbers
all over the place.
Since the publish happens at the top level of my directory I don't
have access to the COMPONENT_VERSION numbers.
I should find a way of fixing that someday but now now.
Thanks much,
craig
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
