Thank you both for reviews.

I'll take your suggestions for the version numbers
next time around.  I need to get this in now.

Clearly I need to fix this over the long run.

Thanks again,
craig

----- [email protected] wrote:

> Craig Mohrman wrote:
> 
> >
> http://jurassic.us.oracle.com/net/mogo/builds3/cmohrman/userland_php-7177478/webrev/
> 
> Looks fine to me.
> 
> > Don't be offended, yet, by the static version numbers
> > all over the place.
> > Since the publish happens at the top level of my directory I don't
> > have access to the COMPONENT_VERSION numbers.
> > I should find a way of fixing that someday but now now.
> 
> Put it in common.mk and include that in all the Makefiles that need
> it?
> 
> Danek
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to