Hey Gary. Thanks for the feedback. I feel very confident about the quality of the fix as we discussed it in another thread. I can post that thread to the JIRA if it helps.
I can create tests for this but it would have to be in a separate branch that would land first (I would think) . That branch would demonstrate the problems (latency in creating new connections) and my branch would resolve it. I already have tests for that so creating a test branch won’t be a problem. I’m slammed at the moment but I can find time to do that next week. I might have found another ActiveMQ issue with a memory leak so I’ll be trying to resolve that as well. Kevin On Fri, Mar 6, 2015 at 7:51 AM, Gary Tully <gary.tu...@gmail.com> wrote: > I had a quick peek at #65 and it seems a little complicated at first > glance :-( > The solution seems elegant enough but I wonder if the problem is somewhere > else. > gc should not have to stop the world and could also be two stage - > removing and purging > so that the contention with producers/consumers is avoided during purge. > > It is great that you did the work to investigate and suggest a solution... > but it will take some dedicated time to validate. > As long as the pull req is attached to an open jira with a fix > version of 5.12 it will be in the mix. > btw - I did not spot a test that shows the problem. If you have some > variant of a test please add it. > > > On 5 March 2015 at 19:56, Kevin Burton <bur...@spinn3r.com> wrote: > > I have two outstanding pull requests for 5.11.x that haven’t been merged. > > > > https://github.com/apache/activemq/pull/65 > > > > https://github.com/apache/activemq/pull/64 > > > > What do I have to do to get these merged? I haven’t received any > feedback > > on them but have seen other merge requests closed. > > > > I don’t want these to be left behind as they fix important scalability > > issues in ActiveMQ > > > > -- > > > > Founder/CEO Spinn3r.com > > Location: *San Francisco, CA* > > blog: http://burtonator.wordpress.com > > … or check out my Google+ profile > > <https://plus.google.com/102718274791889610666/posts> > > <http://spinn3r.com> > -- Founder/CEO Spinn3r.com Location: *San Francisco, CA* blog: http://burtonator.wordpress.com … or check out my Google+ profile <https://plus.google.com/102718274791889610666/posts> <http://spinn3r.com>
