On Sat, Apr 15, 2017 at 12:43 AM Craig Rodrigues <[email protected]> wrote:
> Hi, > > Thanks for working on this. The console view looks a lot better, and > includes more useful information about the > existing builds. Maybe this can effectively replace the old grid and > t-grid views. > > For the waterfall view, you might want to get more opinions. I still > think that the presentation > of information in the buildbot 8 waterfall view is better than 9. > However, I don't feel strongly > about this one, and others may have a different opinion. > I agree on waterfall that it also needs some work. Eight's waterfall is a very clever design from Warner, our first maintainer. It is tightly coupled with the status API, which has been designed for waterfall. There is a complex python generator based design which allow to build the waterfall progressively, from top to bottom. Eight's waterfall and status are tightly coupled, this is the reason why we can't really reuse eight's waterfal code, even if we'd wrote a server side plugin. Nine REST API is on the contrary more generic, model and update oriented. It is KISS, decoupled, scalable, and much easier to test and maintain. Eight's waterfall display the whole db in one view. changes, builds, steps, logs. So in order to implement it, you need to download the whole data. I doubt we can really do it with the current REST api, it would be too slow. This is why it currently only displays builds, but it's not that much useful. I guess we would need a new dashboard centric REST api endpoint which allows to download all the data needed in one request. Regards, Pierre
_______________________________________________ users mailing list [email protected] https://lists.buildbot.net/mailman/listinfo/users
