On Fri, May 6, 2011 at 11:08 AM, Christian Schneider
<christian.schnei...@sopera.com> wrote:
> I think a reference from a setup class to the converters like here is not a
> problem. The bad part of the tangle
> appears when for example DomConverter references the setup class likle
> CorePackageScanResolver.
I dont think any of the Converter classes refer to a
PackageScanResolver. Or in fact for any other classes for the matter.
We DomConverter uses XmlConverter but they are in the same package.
So that part should not be a problem.
Or did I misunderstood something? Where do you see the bad tangle?
>
> So to get rid of the tangles we have to work towards creating an API that
> the implementations can use and avoid that implementations refer to other
> implementations that they should not know about.
>
> But that is hard work ... as Camel does not have a clean API right now.
>
> Christian
>
> Am 06.05.2011 11:02, schrieb Claus Ibsen:
>>
>> Christian Schneider would not like this as the core type converters is
>> hardcoded, which means there would be package tangle ;)
>> As those hard coded type converters are in different packages.
>>
>> public CorePackageScanClassResolver() {
>> converters.add(DomConverter.class);
>> converters.add(StaxConverter.class);
>> converters.add(StreamSourceConverter.class);
>> converters.add(XmlConverter.class);
>> converters.add(CamelConverter.class);
>> converters.add(CollectionConverter.class);
>> converters.add(IOConverter.class);
>> converters.add(NIOConverter.class);
>> converters.add(ObjectConverter.class);
>> converters.add(TimePatternConverter.class);
>> converters.add(StreamCacheConverter.class);
>> converters.add(BeanConverter.class);
>> converters.add(GenericFileConverter.class);
>> converters.add(FutureTypeConverter.class);
>> }
>>
>>
>> Likewise we could make camel-spring be able to add to those core type
>> converters, so we do not have to classpath scanning there as well.
>> This should cut down testing time as well.
>>
>>
>> Any thoughts?
>>
>>
>>
>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> CXF and Camel Architect
> SOPERA - The Application Integration Division of Talend
> http://www.talend.com
>
>
--
Claus Ibsen
-----------------
FuseSource
Email: cib...@fusesource.com
Web: http://fusesource.com
CamelOne 2011: http://fusesource.com/camelone2011/
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/
