I'm not sure how much the ext and the core loggers are out of sync by
now to be honest but the one thing I've spotted is that yes the ext
loggers will log the binary blobs - while the core interceptors disable
it by default,
see 'showBinaryContent' (default is false) - the interceptors will only
issue a one line note that it is a binary content.
additionally the core interceptors do support logging the multipart
requests by default (see showMultipartContent) because often enough
these multiparts have no binary content but it can also be disabled.
Sergey
On 19/08/16 12:16, Christian Schneider wrote:
Can you open some jiras to document the requirements that are not
implemented now?
How should logging the binary contents work? As a switch or should we
simply never log binaries?
Christian
On 19.08.2016 11:42, Sergey Beryozkin wrote:
Hi Christian
As discussed on IRC, IMHO marking core LoggingInterceptors as
deprecated in 3.2.0 (which is what you suggested below) can be very
reasonable.
The problem I've spotted now is that the ext/'new' interceptors do not
support some features that the core/'old' interceptors do, which
unfortunately shows the problem of having a pair of logging features.
Specifically the core interceptors can avoid logging the binary payloads
(multiparts/etc) which was a pretty annoying issue for some users -
seeing some massive binary blobs logged (and partially due to the log
limits) was not good.
IMHO, before the old interceptors can be marked as Deprecated we need
to have those features that are available in the core interceptors
(such as the one I mentioned) synced to the ext loggers
Cheers, Sergey
--
Sergey Beryozkin
Talend Community Coders
http://coders.talend.com/
