On Feb 5, 2014, at 5:06 , Ian Hinder <ian.hin...@aei.mpg.de> wrote: > On 5 Feb 2014, at 06:22, Erik Schnetter <schnet...@cct.lsu.edu> wrote: > >> On Feb 4, 2014, at 23:31 , Frank Loeffler <kn...@cct.lsu.edu> wrote: >> >>> Hi >>> >>> On Tue, Feb 04, 2014 at 10:39:23PM -0500, Erik Schnetter wrote: >>>> I have implemented option 4, since it is the only one that works with our >>>> current infrastructure (Cactus and GetComponents). >>> >>> This now included Boost, a thorn with a source size alone of half a >>> Gigabyte. I don't think this was really intended, at least not at this >>> point where the complete source is still included in the thorn. >> >> I added download lines for all thorns mentioned in our thorn list. >> >> The compressed source code itself has only about 70 MByte. The remainder is >> git repository "overhead", i.e. previous Boost versions. Maybe cleaning the >> git repository would help? > > Hi, > > As far as I remember, Boost is not part of the ET, as it hasn't yet been > agreed that it should be added, or in what form (maybe I missed it?). There > is a ticket about this, but no conclusion about whether the vote happened or > not (https://trac.einsteintoolkit.org/ticket/1410). The minutes of the 8th > August meeting do not mention it. I think the discussion started briefly at > the end of a later telecon but there was not enough time, and it hasn't been > brought up again. Specifically, I think the major objection to Boost is its > size, which can be ameliorated by changing the way the repository is > structured, or the way that external thorns work (e.g. downloading the > library tarball when needed, rather than on checkout). The toolkit is only > supposed to contain components which have been agreed on. Since Boost is not > yet (as far as I know) part of the toolkit, I don't think it should be > downloaded with the toolkit by default. It should be commented out in the > thornlist, so that users can add it back in if they want, until we agree on > whether it should be included, and in what form.
I don't think we should list thorns in our manifest which are not part of the Einstein Toolkit. I would rather remove it completely. Otherwise, we'll have a set of thorns that are "not officially in the ET", but "mentioned in the manifest for convenience". Either adding Boost to the ET (after discussion and addressing the issues), or adding it manually to the thorn list if one wants it even though it is not part of the ET are not difficult. I removed the automated download, and I suggest to remove Boost completely. There are a few other thorns "in limbo", e.g. MemSpeed. Let's follow the proper procedure here, including a review -- that can't hurt... -erik -- Erik Schnetter <schnet...@cct.lsu.edu> http://www.perimeterinstitute.ca/personal/eschnetter/ My email is as private as my paper mail. I therefore support encrypting and signing email messages. Get my PGP key from http://pgp.mit.edu/.
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ Users mailing list Users@einsteintoolkit.org http://lists.einsteintoolkit.org/mailman/listinfo/users
