Am 18.03.2011 um 05:53 schrieb Ron Chen:
> Hi Dave,
>
> I would like to see if we can do some inter-fork collaboration here on the
> list.
Yeah,it must be fixed in various forks...
> Can you review the fix for this issue? If you think it is OK, then I will
> check it into the Open Grid Scheduler project, and you are free to check it
> into the Son of Grid Engine project.
>
> Note that I developed this fix independently, and Oracle has fixed it in a
> more compact way (they have better reg exp Perl programmers!), but Oracle's
> code is not licensed under SISSL (but my fix is under SISSL), so it is better
> not to look at their fix before fixing bugs or else we won't get clean room
> implementations of the code.
Can single line have a copyright? I think it's only the algorithm which is
copyrighted. Otherwise it would end up in: oh, they use i++, we have to use
i+=1.
-- Reuti
> Index: dist/util/resources/jsv/JSV.pm
> ===================================================================
> --- dist/util/resources/jsv/JSV.pm (revision 13)
> +++ dist/util/resources/jsv/JSV.pm (working copy)
> @@ -162,7 +162,7 @@
> $param{$key} = { %h };
> } else {
> # not list command
> - if ($key eq 'A' || $val !~ /,/) {
> + if ($key =~ /CMDARG\d+/ || $key eq 'CMDNAME' || $key eq 'A' || $key
> eq 'N' || $val !~ /,/) {
> # the -A option can have any content, also a comma
> $param{$key} = $val;
> } else {
>
> -Ron
>
>
> --- On Thu, 3/17/11, Rayson Ho <[email protected]> wrote:
>> Thanks for the fix.
>>
>> It's a problem with the Perl code, and I can reproduce the
>> bug outside
>> of SGE. So it should be a small fix and after further
>> testing &
>> checking we will create a patch and share the results with
>> other forks
>> (so not just Open Grid Scheduler will benefit from this bug
>> report).
>>
>> Rayson
>>
>>
>>>
>>> Thanks,
>>> Brad
>>>
>>> _______________________________________________
>>> users mailing list
>>> [email protected]
>>> https://gridengine.org/mailman/listinfo/users
>>>
>>
>> _______________________________________________
>> users mailing list
>> [email protected]
>> https://gridengine.org/mailman/listinfo/users
>>
>
>
>
> _______________________________________________
> users mailing list
> [email protected]
> https://gridengine.org/mailman/listinfo/users
_______________________________________________
users mailing list
[email protected]
https://gridengine.org/mailman/listinfo/users
