Hey Neha,
This looks really promising, I particularly like the ability to commit
offsets for topic/partition tuples over just commit(). Some remarks:
- Constructors link to
http://kafka.apache.org/documentation.html#consumerconfigs for valid
configurations, which lists zookeeper.connect rather than
metadata.broker.list, the value for BROKER_LIST_CONFIG in ConsumerConfig.
- Docs for poll(long) mention consumer.commit(true), which I can't find
in the Consumer docs. For a simple consumer setup, that call is
something that would make a lot of sense.
- Love the addition of MockConsumer, awesome for unittesting :)
Digging these open discussions on API changes on the mailing list btw,
keep up the good work :)
Kind regards,
Mattijs
