Hey, Jose, This is an interesting thought that I hadn't considered before. I think (tentatively) that windowsFor should *not* take the grace period into account.
What I'm thinking is that the method is supposed to return "all windows that contain the provided timestamp" . When we keep window1 open until stream time 7, it's because we're waiting to see if some record with a timestamp in range [0,5) arrives before the overall stream time ticks past 7. But if/when we get that event, its own timestamp is still in the range [0-5). For example, its timestamp is *not* 6 (because then it would belong in window2, not window1). Thus, window1 does not "contain" the timestamp 6, and therefore, windowsFor(6) is not required to return window 1. Does that seem right to you? -John On Thu, Apr 25, 2019 at 6:04 AM Jose Lopez <joseariaslo...@gmail.com> wrote: > Hi all, > > Given that gradePeriodMs is "the time to admit late-arriving events after > the end of the window", I'd expect it is taken into account in > windowsFor(timestamp). E.g.: > > sizeMs = 5 > gracePeriodMs = 2 > advanceMs = 3 > timestamp = 6 > > | window | windowStart | windowEnd | windowsEnd + gracePeriod | > | 1 | 0 | 5 | 7 > | > | 2 | 5 | 10 | 12 > | > ... > > Current output: > windowsFor(timestamp) returns window 2 only. > > Expected output: > windowsFor(timestamp) returns both window 1 and window 2 > > Do you agree with the expected output? Am I missing something? > > Regards, > Jose >
