I dug into this further, and the simplest solution for now is to simply do one of the following:
* replace the “!=“ with “==“ in the test, as Jeff indicated; or * revert the commit Mark identified Both options will restore the original logic. Given that someone already got it wrong, I have clarified the logic in the OMPI master repo. However, I don’t know how long it will be before a 2.0.3 release is issued, so GridEngine users might want to locally fix things in the interim. > On Feb 12, 2017, at 1:52 PM, r...@open-mpi.org wrote: > > Yeah, I’ll fix it this week. The problem is that you can’t check the source > as being default as the default is ssh - so the only way to get the current > code to check for qrsh is to specify something other than the default ssh (it > doesn’t matter what you specify - anything will get you past the erroneous > check so you look for qrsh). > > >> On Feb 9, 2017, at 3:21 PM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> >> wrote: >> >> Yes, we can get it fixed. >> >> Ralph is unavailable this week; I don't know offhand what he meant by his >> prior remarks. It's possible that >> https://github.com/open-mpi/ompi/commit/71ec5cfb436977ea9ad409ba634d27e6addf6fae; >> can you try changing the "!=" on line to be "=="? I.e., from >> >> if (MCA_BASE_VAR_SOURCE_DEFAULT != source) { >> >> to >> >> if (MCA_BASE_VAR_SOURCE_DEFAULT == source) { >> >> I filed https://github.com/open-mpi/ompi/issues/2947 to track the issue. >> >> >>> On Feb 9, 2017, at 6:01 PM, Glenn Johnson <glenn-john...@uiowa.edu> wrote: >>> >>> Will this be fixed in the 2.0.3 release? >>> >>> Thanks. >>> >>> >>> Glenn >>> >>> On Mon, Feb 6, 2017 at 10:45 AM, Mark Dixon <m.c.di...@leeds.ac.uk> wrote: >>> On Mon, 6 Feb 2017, Mark Dixon wrote: >>> ... >>> Ah-ha! "-mca plm_rsh_agent foo" fixes it! >>> >>> Thanks very much - presumably I can stick that in the system-wide >>> openmpi-mca-params.conf for now. >>> ... >>> >>> Except if I do that, it means running ompi outside of the SGE environment >>> no longer works :( >>> >>> Should I just revoke the following commit? >>> >>> Cheers, >>> >>> Mark >>> >>> commit d51c2af76b0c011177aca8e08a5a5fcf9f5e67db >>> Author: Jeff Squyres <jsquy...@cisco.com> >>> Date: Tue Aug 16 06:58:20 2016 -0500 >>> >>> rsh: robustify the check for plm_rsh_agent default value >>> >>> Don't strcmp against the default value -- the default value may change >>> over time. Instead, check to see if the MCA var source is not >>> DEFAULT. >>> >>> Signed-off-by: Jeff Squyres <jsquy...@cisco.com> >>> >>> (cherry picked from commit >>> open-mpi/ompi@71ec5cfb436977ea9ad409ba634d27e6addf6fae) >>> >>> >>> _______________________________________________ >>> users mailing list >>> users@lists.open-mpi.org >>> https://rfd.newmexicoconsortium.org/mailman/listinfo/users >>> >>> _______________________________________________ >>> users mailing list >>> users@lists.open-mpi.org >>> https://rfd.newmexicoconsortium.org/mailman/listinfo/users >> >> >> -- >> Jeff Squyres >> jsquy...@cisco.com >> >> _______________________________________________ >> users mailing list >> users@lists.open-mpi.org >> https://rfd.newmexicoconsortium.org/mailman/listinfo/users > > _______________________________________________ > users mailing list > users@lists.open-mpi.org > https://rfd.newmexicoconsortium.org/mailman/listinfo/users _______________________________________________ users mailing list users@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/users
