On 02/05/08 12:52, kokoska rokoska wrote:
I would like to have patch for 1.3.0 too :-)
thanks for volunteering to test. Here is the attached patch. Let me know
if works so I can commit on SVN.
Cheers,
Daniel
Thanks, regards
kokoska.rokoska
Daniel-Constantin Mierla napsal(a):
There is bug mistakenly introduced about 2 years ago, if I could spot it
right on the svn log. A wrong variable for registrar address was used. I
have just made a commit on trunk. Can you test and let me know if works
now? If you need patch for 1.3 I can send it to you -- I will backport
after some testing is done.
Thanks,
Daniel
On 02/05/08 11:37, Iñaki Baz Castillo wrote:
On Tuesday 05 February 2008 10:08:16 Dan-Cristian Bogos wrote:
Iñaki,
it looks like I have misunderstood your problem.
I was speaking about "202 Accepted" confirmation and not a new MESSAGE.
Yes, that was what I meant ;)
Why would you need a new message?
Because it's the only way that any UAC will show the notification to its user.
For example:
- If X-Lite sends a MESSAGE and it's stored and replied by proxy with "202
Accepted" then XLite UI will show nothing to the user, but message correctly
received by destination, so he will think that the destinaiton is ireceiving
him messages but ignoring them.
- If the message is stored and proxy replies "404 User Not Found, MEssage
Stored" then XLite will just show in the UI: "404 User is not online".
- Twinkle will not show the code description for a 202, but it will do it in a
negative reply (404 for example), but Twinkle IM is not very advanced yet in
usability terms.
Best regards.
_______________________________________________
Users mailing list
[email protected]
http://lists.openser.org/cgi-bin/mailman/listinfo/users
_______________________________________________
Users mailing list
[email protected]
http://lists.openser.org/cgi-bin/mailman/listinfo/users
Index: modules/msilo/msilo.c
===================================================================
--- modules/msilo/msilo.c (revision 3623)
+++ modules/msilo/msilo.c (working copy)
@@ -149,8 +149,6 @@
str msg_type = { "MESSAGE", 7 };
-str reg_addr;
-
#define MSILO_PRINTBUF_SIZE 1024
static char msilo_printbuf[MSILO_PRINTBUF_SIZE];
@@ -456,8 +454,8 @@
}
}
- if(pto->uri.len == reg_addr.len &&
- !strncasecmp(pto->uri.s, reg_addr.s, reg_addr.len))
+ if(pto->uri.len == ms_registrar.len &&
+ !strncasecmp(pto->uri.s, ms_registrar.s, ms_registrar.len))
{
LM_DBG("message to MSILO REGISTRAR!\n");
goto error;
@@ -575,8 +573,8 @@
pfrom = (struct to_body*)msg->from->parsed;
LM_DBG("'From' header: <%.*s>\n", pfrom->uri.len, pfrom->uri.s);
- if(reg_addr.s && pfrom->uri.len == reg_addr.len &&
- !strncasecmp(pfrom->uri.s, reg_addr.s, reg_addr.len))
+ if(ms_registrar.s && pfrom->uri.len == ms_registrar.len &&
+ !strncasecmp(pfrom->uri.s, ms_registrar.s, ms_registrar.len))
{
LM_DBG("message from MSILO REGISTRAR!\n");
goto error;
@@ -686,15 +684,15 @@
update_stat(ms_stored_msgs, 1);
#endif
- if(reg_addr.len <= 0
- || reg_addr.len+CONTACT_PREFIX_LEN+CONTACT_SUFFIX_LEN+1>=1024)
+ if(ms_registrar.len <= 0
+ || ms_registrar.len+CONTACT_PREFIX_LEN+CONTACT_SUFFIX_LEN+1>=1024)
goto done;
LM_DBG("sending info message.\n");
strcpy(buf1, CONTACT_PREFIX);
- strncat(buf1,reg_addr.s,reg_addr.len);
+ strncat(buf1,ms_registrar.s,ms_registrar.len);
strncat(buf1, CONTACT_SUFFIX, CONTACT_SUFFIX_LEN);
- str_hdr.len = CONTACT_PREFIX_LEN+reg_addr.len+CONTACT_SUFFIX_LEN;
+ str_hdr.len = CONTACT_PREFIX_LEN+ms_registrar.len+CONTACT_SUFFIX_LEN;
str_hdr.s = buf1;
strncpy(buf, "User [", 6);
@@ -736,7 +734,7 @@
tmb.t_request(&msg_type, /* Type of the message */
(ctaddr.s)?&ctaddr:&pfrom->uri, /* Request-URI */
&pfrom->uri, /* To */
- ®_addr, /* From */
+ &ms_registrar, /* From */
&str_hdr, /* Optional headers including CRLF */
&body, /* Message body */
(ms_outbound_proxy.s)?&ms_outbound_proxy:0, /* outbound uri */
_______________________________________________
Users mailing list
[email protected]
http://lists.openser.org/cgi-bin/mailman/listinfo/users
