On Sat, 1 Oct 2022 at 01:22, Ceki Gülcü <c...@qos.ch> wrote: > > > Hello all, > > The logback is attempting to migrate to Junit 5. As a consequence of > this migration, a handful of tests that were previously successful, now > fail. > > For example, the ch.qos.logback.classic.net.DilutedSMTPAppenderTest > recently failed with the following error: > > java.lang.NoClassDefFoundError: jakarta/mail/internet/AddressException > > During surefire execution, the j.m.i.AddressException class is not > found. It is part of jakarta-mail.jar. I believe this artifact is on the > module path but somehow is not resolved. > > Anyway, upgrading org.assertj:assertj-core from l.7.1 to 3.23.1 seems to > help. Don't ask me why... > > I am also puzzled by the fact that many JMPS modularized artifacts are > placed on the class path instead of the module path when the tests are run.
well maybe the problem is some are on module path and some others on the class path.. when migrating the Jetty project from surefire M5 to M7 I had a lot of jpms issues because some logic changed especially in this part. I wanted to have some opinions on what sort of configurations we could add but this didn't get much attention :) (https://issues.apache.org/jira/browse/SUREFIRE-2097) Maybe nobody really cares of jpms... > > Anyway, I think I may have stumbled upon a bug in Maven or the surefire > plugin. Indeed, when I run mvn install from within the logback-classic > module, the DilutedSMTPAppenderTest mentioned above succeeds. > > However, when I run it as > > mvn install -Dtest=ch.qos.logback.classic.net.DilutedSMTPAppenderTest > > the test fails with the following exception > > [ERROR] > ch.qos.logback.classic.net.DilutedSMTPAppenderTest.testTriggeringPolicy > Time elapsed: 0.001 s <<< ERROR! > java.lang.NoClassDefFoundError: jakarta/mail/internet/AddressException > at > ch.qos.logback.classic@1.4.2-SNAPSHOT/ch.qos.logback.classic.net.DilutedSMTPAppenderTest.setUp(DilutedSMTPAppenderTest.java:41) > at > java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) > at java.base/java.lang.reflect.Method.invoke(Method.java:578) > > [cut]... > Caused by: java.lang.ClassNotFoundException: > jakarta.mail.internet.AddressException > at > java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) > at > java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) > at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) > ... 74 more > > > Comparing the command line of the two executions, the 'mvn install' > execution has jakarta-mail-api on the module-path, whereas the 'mvn test > -D=..." has jakarta-mail-api on the class-path. > > If you wish to confirm this, I have created tag 'possible_mvn_issue' > in the logback repository on github . > > https://github.com/qos-ch/logback/releases/tag/possible_mvn_issue > > Let me know if this merits the creation of a Jira issue. > > Your feedback would be most appreciated. > > -- > Ceki Gülcü > > Sponsoring SLF4J/logback/reload4j at https://github.com/sponsors/qos-ch > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@maven.apache.org > For additional commands, e-mail: users-h...@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org
