I think Estelle's mail lacked the context so I added it below. She made a reproducer for a probable bug regarding missing exclusions from the dependency-reduced-pom.xml in recent versions of the Shade plugin when run in parrallel. Thanks Estelle !
Francois Le ven. 19 janv. 2024 à 18:37, Estelle Bremont <bremont.este...@gmail.com> a écrit : > Hello ! > I work with François. Here's a quite simple example reproducing the problem > : https://github.com/stl543/shadeMT > It has a parent pom so the 4 child modules have strictly the same > configuration apart from their artifactId. > > The following command will give you results varying between 12, 16 and 20 > showing that <exclusions> are sometimes missing from the generated > dependency-reduced-pom.xml. Usually all the poms are generated the same > (which is expected) but sometimes some have exclusions that others do not. > > mvn clean package -T 1C && find . -name "dependency-reduced-pom.xml" -exec > bash -c 'cat $0 | grep exclu | wc -l ' {} \; > > > > - shade 3.5.1 & 3.4.1 : have the problem of missing exclusions > - shade ranging from 3.2.1 to 3.4.0 have freeze problems (known bug) > - shade 3.2.0 : ok > - shade 3.1.0 : ok > > Do you think I should open an issue directly with the shade plugin ? > Best regards, > Estelle > ---------- Forwarded message --------- De : Alexander Kriegisch <alexan...@kriegisch.name> Date: ven. 12 janv. 2024 à 03:21 Subject: Re: Random missing exclusions in dependency-reduced-pom when run in // To: <users@maven.apache.org> Hello François. I am not a committer in any Apache project, but I have contributed to Shade here and there. A reproducer would certainly help, so please post GitHub link, as soon as you have one. If it is clearly reproducible, it might also be wort opening an issue to have something to commit on, if anyone feels like creating a PR. Cheers -- Alexander Kriegisch https://scrum-master.de Francois Marot schrieb am 11.01.2024 16:16 (GMT +07:00): > Hello, > > First let me wish the Maven community a happy new year. > I recently faced a problem with the shade plugin generating randomly > different dependency-reduced-pom.xml. > The difference lies in exclusions defined in miscellaneous dependencies > randomly being missing in the pom. > This part of the build builds multiple (4) project in // (-T 1C) all using > the shade plugin to generate a dependency-reduced-pom.xml. > All my tests are done with the latest maven-shade-plugin 3.5.1 > I think there is a concurrency issue somewhere and I think it is in Maven > model being manipulated by the shade plugin. > > With Maven 3.9.4 I was able to reproduce the problem only once. With 3.9.5 > & 3.9.6 it started to be a lot more reproducible. > Could the Shade plugin use Maven model in a non thread safe way ? Any idea > welcome ! > (I'm sorry and haven't taken the time to dev a SCCE(http://sscce.org/) yet > but I may try if no one has an idea of what is happening) > > Regards > Francois >
