On Fri, 27 Nov 2009 16:01:59 +0900, Jiro SEKIBA <[email protected]> wrote: > Delete redundant mark_inode_dirty() calls > > Signed-off-by: Jiro SEKIBA <[email protected]> > --- > fs/nilfs2/namei.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c > index f952439..33972c6 100644 > --- a/fs/nilfs2/namei.c > +++ b/fs/nilfs2/namei.c > @@ -280,7 +280,6 @@ out: > > out_fail: > drop_nlink(inode); > - mark_inode_dirty(inode); > drop_nlink(inode); > mark_inode_dirty(inode); > iput(inode); > @@ -405,7 +404,6 @@ static int nilfs_rename(struct inode *old_dir, struct > dentry *old_dentry, > if (!new_de) > goto out_dir; > inc_nlink(old_inode); > - mark_inode_dirty(old_inode); > nilfs_set_link(new_dir, new_de, new_page, old_inode); > mark_inode_dirty(new_dir); > new_inode->i_ctime = CURRENT_TIME; > @@ -420,7 +418,6 @@ static int nilfs_rename(struct inode *old_dir, struct > dentry *old_dentry, > goto out_dir; > } > inc_nlink(old_inode); > - mark_inode_dirty(old_inode); > err = nilfs_add_link(new_dentry, old_inode); > if (err) { > drop_nlink(old_inode); > -- > 1.5.6.5
You can also remove the first mark_inode_dirty(dir) call in nilfs_mkdir() because nilfs_add_link() will mark the inode of parent directory dirty. Ryusuke Konishi _______________________________________________ users mailing list [email protected] https://www.nilfs.org/mailman/listinfo/users
