Hi, At Fri, 27 Nov 2009 18:30:15 +0900 (JST), Ryusuke Konishi wrote: > > On Fri, 27 Nov 2009 17:10:48 +0900 (JST), Ryusuke Konishi wrote: > > Hi, > > On Fri, 27 Nov 2009 16:01:55 +0900, Jiro SEKIBA <[email protected]> wrote: > > > Hi, > > > > > > This is a series of patches to reduce redandunt mark_inode_dirty calls. > > > > > > Many functions call mark_inode_dirty() whenever they change inode object. > > > However, it is redundant to call mark_inode_dirty() to same inode object > > > within a transaction. > > > > > > Last patch also replaces all mark_inode_dirty() calls as > > > nilfs_mark_inode_dirty(), to reduce deep function call tree. > > > > > > > > > fs/nilfs2/dir.c | 2 +- > > > fs/nilfs2/inode.c | 6 +++--- > > > fs/nilfs2/namei.c | 34 +++++++++++++++++----------------- > > > 3 files changed, 21 insertions(+), 21 deletions(-) > > > > Thank you for sending this series. > > I agree with the basic policy of the changes. > > > > All right, I will review the patches as soon as possible. > > > > Thanks, > > Ryusuke Konishi > > Well wrought patches! > > I have two comments to brush up the series. > Later, I will comment on the corresponding ones.
Thank you for the review! I'll revise it and send a series again. > BTW, the diff stat looks smaller than the actual changes. > My git-diff was as follows ;) Grr, look like it's the only the last diff stat.. I missed "9" to generate diff stat.. > fs/nilfs2/dir.c | 24 ++++++--------- > fs/nilfs2/inode.c | 7 ++-- > fs/nilfs2/namei.c | 85 ++++++++++++++++++++++++++++++++++------------------ > 3 files changed, 68 insertions(+), 48 deletions(-) > > Thanks, > Ryusuke Konishi > _______________________________________________ > users mailing list > [email protected] > https://www.nilfs.org/mailman/listinfo/users > > > -- Jiro SEKIBA <[email protected]> _______________________________________________ users mailing list [email protected] https://www.nilfs.org/mailman/listinfo/users
